content/renderer/render_frame_impl.cc - Issue 2215133002: Change signature of OnConnect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2215133002: Change signature of OnConnect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup

Patch Set: . Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 9fb4467fa3001951d3bbc3694a09ca2bc32629fe..04258d4b71ced1ec84f059ca2bf9326a2d26ddd1 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -1122,7 +1122,7 @@ RenderFrameImpl::RenderFrameImpl(const CreateParams& params)

// We don't have a shell::Connection at this point, so use nullptr.

// TODO(beng): We should fix this, so we can apply policy about which

// interfaces get exposed.

- interface_registry_.reset(new shell::InterfaceRegistry(nullptr));

+ interface_registry_.reset(new shell::InterfaceRegistry);

shell::mojom::InterfaceProviderPtr remote_interfaces;

pending_remote_interface_provider_request_ = GetProxy(&remote_interfaces);

remote_interfaces_.reset(new shell::InterfaceProvider);