Disable Print in the context menu when a modal dialog is shown

chrome/browser/renderer_context_menu/render_view_context_menu.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <set>
@@ skipping 1409 matching lines @@
     bool enabled = false;
     if (RenderViewContextMenuBase::IsCommandIdKnown(id, &enabled))
       return enabled;
   }
 
   CoreTabHelper* core_tab_helper =
       CoreTabHelper::FromWebContents(source_web_contents_);
   int content_restrictions = 0;
   if (core_tab_helper)
     content_restrictions = core_tab_helper->content_restrictions();
-  if (id == IDC_PRINT && (content_restrictions & CONTENT_RESTRICTION_PRINT))

[Lei Zhang, 2016/08/04 23:54:08]

Maybe just leave this check in since it's relatively cheap to do?

[takumif, 2016/08/05 00:40:08]

Done.

-    return false;
 
   if (id == IDC_SAVE_PAGE &&
       (content_restrictions & CONTENT_RESTRICTION_SAVE)) {
     return false;
   }
 
   PrefService* prefs = GetPrefs(browser_context_);
 
   // Allow Spell Check language items on sub menu for text area context menu.
   if ((id >= IDC_SPELLCHECK_LANGUAGES_FIRST) &&
@@ skipping 134 matching lines @@
 
     case IDC_CONTENT_CONTEXT_SELECTALL:
       return !!(params_.edit_flags & WebContextMenuData::CanSelectAll);
 
     case IDC_CONTENT_CONTEXT_OPENLINKOFFTHERECORD:
       return !browser_context_->IsOffTheRecord() &&
              params_.link_url.is_valid() &&
              incognito_avail != IncognitoModePrefs::DISABLED;
 
     case IDC_PRINT:
-      return prefs->GetBoolean(prefs::kPrintingEnabled) &&
-             (params_.media_type == WebContextMenuData::MediaTypeNone ||
-              params_.media_flags & WebContextMenuData::MediaCanPrint);
+      return IsPrintPreviewEnabled();
 
     case IDC_CONTENT_CONTEXT_SEARCHWEBFOR:
     case IDC_CONTENT_CONTEXT_GOTOURL:
     case IDC_SPELLPANEL_TOGGLE:
     case IDC_CONTENT_CONTEXT_LANGUAGE_SETTINGS:
       return true;
     case IDC_CHECK_SPELLING_WHILE_TYPING:
       return prefs->GetBoolean(prefs::kEnableContinuousSpellcheck);
 
 #if !defined(OS_MACOSX) && defined(OS_POSIX)
@@ skipping 476 matching lines @@
 
 bool RenderViewContextMenu::IsPasteAndMatchStyleEnabled() const {
   if (!(params_.edit_flags & WebContextMenuData::CanPaste))
     return false;
 
   return ui::Clipboard::GetForCurrentThread()->IsFormatAvailable(
       ui::Clipboard::GetPlainTextFormatType(),
       ui::CLIPBOARD_TYPE_COPY_PASTE);
 }
 
+bool RenderViewContextMenu::IsPrintPreviewEnabled() const {
+  Browser* browser = chrome::FindLastActive();

[Lei Zhang, 2016/08/04 23:54:09]

Seems everyone else here is calling
chrome::FindBrowserWithWebContents(source_web_contents_);

Does that seem more appropriate?

[takumif, 2016/08/05 00:40:08]

chrome::FindBrowserWithWebContents returns null in some cases (in particular
when a modal dialog is open), so just for disabling Print for modal dialogs,
that'd work as well. We wouldn't even have to call chrome::CanPrint in that
case. However, that feels a bit less straightforward to me, and I thought it
might be better to be consistent with the hotdog menu option, which relies on
chrome::CanPrint. What do you think?

[Lei Zhang, 2016/08/05 01:48:47]

How is checking chrome::FindBrowserWithWebContents() returning a nullptr any
different from checking if chrome::FindLastActive() returning a nullptr?

[takumif, 2016/08/05 18:12:29]

It was unexpected to me that chrome::FindBrowserWithWebContents() would return a
nullptr when a modal dialog is open, but it might be better to just take note of
that in a comment. Changing.

+  return browser &&
+         chrome::CanPrint(browser) &&
+         (params_.media_type == WebContextMenuData::MediaTypeNone ||

[Lei Zhang, 2016/08/04 23:54:09]

Check these separately first because it is the cheapest check?

[takumif, 2016/08/05 00:40:08]

Done.

+          params_.media_flags & WebContextMenuData::MediaCanPrint);
+}
+
 bool RenderViewContextMenu::IsRouteMediaEnabled() const {
   if (!media_router::MediaRouterEnabled(browser_context_))
     return false;
 
   Browser* browser = chrome::FindBrowserWithWebContents(source_web_contents_);
   if (!browser)
     return false;
 
   // Disable the command if there is an active modal dialog.
   // We don't use |source_web_contents_| here because it could be the
@@ skipping 343 matching lines @@
   source_web_contents_->GetRenderViewHost()->
       ExecuteMediaPlayerActionAtLocation(location, action);
 }
 
 void RenderViewContextMenu::PluginActionAt(
     const gfx::Point& location,
     const WebPluginAction& action) {
   source_web_contents_->GetRenderViewHost()->
       ExecutePluginActionAtLocation(location, action);
 }