Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2215073002: bluetooth: Suggest Origin Trial in console. (Closed)

Created:
4 years, 4 months ago by scheib
Modified:
4 years, 4 months ago
Reviewers:
ortuno
CC:
blink-reviews, chromium-reviews, haraken, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Suggest Origin Trial in console. Show a message in the developer console when developers enable Web Bluetooth via command line flag and use bluetooth.requestDevice. Inform them that the feature is available in Origin Trial. Do not show the message on sites where the feature is enabled due to the origin trial. BUG=632103 Committed: https://crrev.com/38017e74b490422549878f87f5aa285ab148a97a Cr-Commit-Position: refs/heads/master@{#410082}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/bluetooth/Bluetooth.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp View 3 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
scheib
4 years, 4 months ago (2016-08-04 21:45:09 UTC) #3
ortuno
lgtm
4 years, 4 months ago (2016-08-04 21:51:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2215073002/1
4 years, 4 months ago (2016-08-04 22:15:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/274678)
4 years, 4 months ago (2016-08-04 23:56:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2215073002/1
4 years, 4 months ago (2016-08-05 15:45:04 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 16:53:45 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 16:55:37 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38017e74b490422549878f87f5aa285ab148a97a
Cr-Commit-Position: refs/heads/master@{#410082}

Powered by Google App Engine
This is Rietveld 408576698