Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2405)

Unified Diff: chrome/browser/printing/print_preview_dialog_controller.cc

Issue 2215063002: Fix Print Preview Alt + Left Arrow breakage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use test 1, revert controller changes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/printing/print_preview_dialog_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_preview_dialog_controller.cc
diff --git a/chrome/browser/printing/print_preview_dialog_controller.cc b/chrome/browser/printing/print_preview_dialog_controller.cc
index 6211d5c39e99661f74f0542e1160510e06b3018d..7e0a8968c2607badf6289d644d9c25dc0135dfe1 100644
--- a/chrome/browser/printing/print_preview_dialog_controller.cc
+++ b/chrome/browser/printing/print_preview_dialog_controller.cc
@@ -351,8 +351,12 @@ void PrintPreviewDialogController::OnNavEntryCommitted(
ui::PageTransition type = details->entry->GetTransitionType();
content::NavigationType nav_type = details->type;
if (nav_type == content::NAVIGATION_TYPE_EXISTING_PAGE &&
- (ui::PageTransitionCoreTypeIs(type, ui::PAGE_TRANSITION_TYPED) ||
- ui::PageTransitionCoreTypeIs(type, ui::PAGE_TRANSITION_LINK)))
+ (ui::PageTransitionTypeIncludingQualifiersIs(
+ type,
+ ui::PageTransitionFromInt(ui::PAGE_TRANSITION_TYPED |
+ ui::PAGE_TRANSITION_FROM_ADDRESS_BAR)) ||
+ ui::PageTransitionTypeIncludingQualifiersIs(type,
+ ui::PAGE_TRANSITION_LINK)))
return;
}
« no previous file with comments | « no previous file | chrome/browser/printing/print_preview_dialog_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698