Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Unified Diff: ui/compositor/scoped_layer_animation_settings.cc

Issue 2215043002: Removing unused functionality from ScopedLayerAnimationSettings: inverse animations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/compositor/scoped_layer_animation_settings.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/compositor/scoped_layer_animation_settings.cc
diff --git a/ui/compositor/scoped_layer_animation_settings.cc b/ui/compositor/scoped_layer_animation_settings.cc
index 912d8bd5ff54e6e3f19e6baa67d38a1929da43cd..5688d3cf05dc7ae5896be2deb8bacad9ba876d5e 100644
--- a/ui/compositor/scoped_layer_animation_settings.cc
+++ b/ui/compositor/scoped_layer_animation_settings.cc
@@ -19,65 +19,6 @@ const int kDefaultTransitionDurationMs = 200;
namespace ui {
-// InvertingObserver -----------------------------------------------------------
-class InvertingObserver : public ImplicitAnimationObserver {
- public:
- InvertingObserver()
- : base_layer_(NULL) {
- }
-
- ~InvertingObserver() override {}
-
- void SetLayer(Layer* base_layer) { base_layer_ = base_layer; }
-
- Layer* layer() { return base_layer_; }
-
- void AddInverselyAnimatedLayer(Layer* inverse_layer) {
- inverse_layers_.push_back(inverse_layer);
- }
-
- void OnImplicitAnimationsCompleted() override {}
-
- void OnLayerAnimationScheduled(LayerAnimationSequence* sequence) override {
- DCHECK(base_layer_ != NULL)
- << "Must set base layer with ScopedLayerAnimationSettings::"
- << "SetInverslyAnimatedBaseLayer";
- gfx::Transform base_transform = base_layer_->transform();
- std::unique_ptr<LayerAnimationElement> inverse =
- GetInverseElement(sequence, base_transform);
-
- for (std::vector<Layer*>::const_iterator i =
- inverse_layers_.begin(); i != inverse_layers_.end(); ++i) {
- (*i)->GetAnimator()->StartAnimation(new LayerAnimationSequence(
- LayerAnimationElement::CloneInverseTransformElement(
- inverse.get())));
- }
- }
- private:
- std::unique_ptr<LayerAnimationElement> GetInverseElement(
- LayerAnimationSequence* sequence,
- gfx::Transform base) const {
- const size_t expected_size = 1;
- DCHECK_EQ(expected_size, sequence->size())
- << "Inverse supported only for single element sequences.";
-
- LayerAnimationElement* element = sequence->FirstElement();
- DCHECK_EQ(static_cast<LayerAnimationElement::AnimatableProperties>(
- LayerAnimationElement::TRANSFORM),
- element->properties())
- << "Only transform animations are currently invertible.";
-
- std::unique_ptr<LayerAnimationElement> to_return(
- LayerAnimationElement::CreateInverseTransformElement(base, element));
- return to_return;
- }
-
- Layer* base_layer_;
- // child layers
- std::vector<Layer*> inverse_layers_;
-};
-
-
// ScopedLayerAnimationSettings ------------------------------------------------
ScopedLayerAnimationSettings::ScopedLayerAnimationSettings(
scoped_refptr<LayerAnimator> animator)
@@ -86,8 +27,7 @@ ScopedLayerAnimationSettings::ScopedLayerAnimationSettings(
animator->is_transition_duration_locked_),
old_transition_duration_(animator->GetTransitionDuration()),
old_tween_type_(animator->tween_type()),
- old_preemption_strategy_(animator->preemption_strategy()),
- inverse_observer_(new InvertingObserver()) {
+ old_preemption_strategy_(animator->preemption_strategy()) {
SetTransitionDuration(
base::TimeDelta::FromMilliseconds(kDefaultTransitionDurationMs));
}
@@ -104,10 +44,6 @@ ScopedLayerAnimationSettings::~ScopedLayerAnimationSettings() {
animator_->observers_.RemoveObserver(*i);
(*i)->SetActive(true);
}
-
- if (inverse_observer_->layer()) {
- animator_->observers_.RemoveObserver(inverse_observer_.get());
- }
}
void ScopedLayerAnimationSettings::AddObserver(
@@ -147,18 +83,4 @@ ScopedLayerAnimationSettings::GetPreemptionStrategy() const {
return animator_->preemption_strategy();
}
-void ScopedLayerAnimationSettings::SetInverselyAnimatedBaseLayer(Layer* base) {
- if (inverse_observer_->layer() && !base) {
- animator_->RemoveObserver(inverse_observer_.get());
- } else if (base && !(inverse_observer_->layer())) {
- animator_->AddObserver(inverse_observer_.get());
- }
- inverse_observer_->SetLayer(base);
-}
-
-void ScopedLayerAnimationSettings::AddInverselyAnimatedLayer(
- Layer* inverse_layer) {
- inverse_observer_->AddInverselyAnimatedLayer(inverse_layer);
-}
-
} // namespace ui
« no previous file with comments | « ui/compositor/scoped_layer_animation_settings.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698