Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 22150005: file_manager: Rename file_manager_event_router.h to event_router.h (Closed)

Created:
7 years, 4 months ago by satorux1
Modified:
7 years, 4 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

file_manager: Rename file_manager_event_router.h to event_router.h Having "file_manager" in the file name is redndant as the file is in "file_manager" directory. Along the way, rename FileManagerEventRouter to EventRouter as the class is in "file_manager" namespace. BUG=268248 TEST=none R=hashimoto@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215775

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -1146 lines) Patch
A + chrome/browser/chromeos/extensions/file_manager/event_router.h View 4 chunks +8 lines, -8 lines 0 comments Download
A + chrome/browser/chromeos/extensions/file_manager/event_router.cc View 35 chunks +67 lines, -73 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/external_filesystem_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.h View 1 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/file_manager_event_router.h View 1 chunk +0 lines, -174 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/file_manager_event_router.cc View 1 chunk +0 lines, -875 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_manager_event_router_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
satorux1
7 years, 4 months ago (2013-08-05 08:02:17 UTC) #1
hashimoto
lgtm https://codereview.chromium.org/22150005/diff/1/chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.h File chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.h (right): https://codereview.chromium.org/22150005/diff/1/chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.h#newcode29 chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.h:29: EventRouter* event_router() { nit: Can't this function be ...
7 years, 4 months ago (2013-08-05 08:10:03 UTC) #2
satorux1
https://codereview.chromium.org/22150005/diff/1/chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.h File chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.h (right): https://codereview.chromium.org/22150005/diff/1/chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.h#newcode29 chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.h:29: EventRouter* event_router() { On 2013/08/05 08:10:03, hashimoto wrote: > ...
7 years, 4 months ago (2013-08-05 22:37:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/22150005/43001
7 years, 4 months ago (2013-08-06 02:12:24 UTC) #4
satorux1
7 years, 4 months ago (2013-08-06 03:05:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r215775 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698