fix #26965, allow promotion from type param upper bound in strong mode

fix #26965, allow promotion from type param upper bound in strong mode

Also updates the changelog with this, and adds notes on a few other missing strong mode features.

R=leafp@google.com

Committed: https://github.com/dart-lang/sdk/commit/efe9f1140d0ff8a0f6764d7520edf14446dcc9e2

[Jennifer Messerly, 2016-08-04 15:53:42]

jmesserly@google.com changed reviewers:
+ leafp@google.com

[Leaf, 2016-08-04 16:49:07]

lgtm.  We should make a changelog note that this is a breaking change.

https://codereview.chromium.org/2214833002/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/strong/checker_test.dart (right):

https://codereview.chromium.org/2214833002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/checker_test.dart:3417: if (object is String)
print(/*info:DYNAMIC_INVOKE*/object.substring(1));
There should be a type error here, shouldn't there, since substring is not
defined on num?

[Jennifer Messerly, 2016-08-04 18:26:16]

SGTM. I'll wait on the other CL that has the initial changelog entry (to make
merging easier)

https://codereview.chromium.org/2214833002/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/strong/checker_test.dart (right):

https://codereview.chromium.org/2214833002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/checker_test.dart:3417: if (object is String)
print(/*info:DYNAMIC_INVOKE*/object.substring(1));
On 2016/08/04 16:49:06, Leaf wrote:
> There should be a type error here, shouldn't there, since substring is not
> defined on num?  

yeah, it is, but we suppress the UNDEFINED_METHOD error from the test
expectations =\. Probably we should stop doing that.
https://github.com/dart-lang/sdk/blob/643fdb9dc8371adfd04ca8ab2acee87b53c8f2d...

(I think it's a hold over from when we didn't validate Analyzer-produced
messages at all)

[Jennifer Messerly, 2016-08-05 14:37:10]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[Jennifer Messerly, 2016-08-05 14:37:10]

I've updated the changelog. Also added no-implicit-casts and no-implicit-dynamic
which are in this release. Leaf or Vijay mind taking a look? :)

[Jennifer Messerly, 2016-08-05 14:37:57]

Description was changed from

==========
fix #26965, allow promotion from type param upper bound in strong mode
==========

to

==========
fix #26965, allow promotion from type param upper bound in strong mode

Also updates the changelog with this, and adds notes on a few other missing
strong mode features.
==========

[Leaf, 2016-08-05 15:49:43]

lgtm

[Jennifer Messerly, 2016-08-05 15:51:49]

Description was changed from

==========
fix #26965, allow promotion from type param upper bound in strong mode

Also updates the changelog with this, and adds notes on a few other missing
strong mode features.
==========

to

==========
fix #26965, allow promotion from type param upper bound in strong mode

Also updates the changelog with this, and adds notes on a few other missing
strong mode features.

R=leafp@google.com

Committed:
https://github.com/dart-lang/sdk/commit/efe9f1140d0ff8a0f6764d7520edf14446dcc9e2
==========

[Jennifer Messerly, 2016-08-05 15:51:51]

Committed patchset #3 (id:40001) manually as
efe9f1140d0ff8a0f6764d7520edf14446dcc9e2 (presubmit successful).