Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1429)

Unified Diff: build/config/sanitizers/BUILD.gn

Issue 2214783002: win/asan 64-bit is in development; make sure we don't accidentally use it yet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: todo Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/sanitizers/BUILD.gn
diff --git a/build/config/sanitizers/BUILD.gn b/build/config/sanitizers/BUILD.gn
index 08ecb8d337a535288a04d46a0e04e93784d91dd4..1b16a8e4b422e75a6972fde6128160040cd9347a 100644
--- a/build/config/sanitizers/BUILD.gn
+++ b/build/config/sanitizers/BUILD.gn
@@ -252,8 +252,9 @@ config("asan_flags") {
# and dlls, see link_executable and link_shared_library below.
# This here handles only the component build.
if (target_cpu == "x64") {
- # Windows 64-bit.
+ # Windows 64-bit. TODO(etienneb): Remove the assert when this is ready.
if (is_component_build) {
+ assert(false, "win/asan does not work in 64-bit yet")
libs = [
"clang_rt.asan_dynamic-x86_64.lib",
"clang_rt.asan_dynamic_runtime_thunk-x86_64.lib",
@@ -275,7 +276,8 @@ config("asan_flags") {
config("link_executable") {
if (is_asan && is_win && !is_component_build) {
if (target_cpu == "x64") {
- # Windows 64-bit.
+ # Windows 64-bit. TODO(etienneb): Remove the assert when this is ready.
+ assert(false, "win/asan does not work in 64-bit yet")
libs = [ "clang_rt.asan-x86_64.lib" ]
} else {
assert(target_cpu == "x86", "WinASan unsupported architecture")
@@ -287,7 +289,8 @@ config("link_executable") {
config("link_shared_library") {
if (is_asan && is_win && !is_component_build) {
if (target_cpu == "x64") {
- # Windows 64-bit.
+ # Windows 64-bit. TODO(etienneb): Remove the assert when this is ready.
+ assert(false, "win/asan does not work in 64-bit yet")
libs = [ "clang_rt.asan_dll_thunk-x86_64.lib" ]
} else {
assert(target_cpu == "x86", "WinASan unsupported architecture")
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698