Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: tools/perf/benchmarks/page_cycler.py

Issue 2214773002: [perf] Disable page_cycler.typical_25.reference on Mac Yosemite (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/page_cycler.py
diff --git a/tools/perf/benchmarks/page_cycler.py b/tools/perf/benchmarks/page_cycler.py
index e8883146a8476a09a6bfa7116e54771e2f282e17..a62424fc2e825dab80c3c9474b08fe91f67f3846 100644
--- a/tools/perf/benchmarks/page_cycler.py
+++ b/tools/perf/benchmarks/page_cycler.py
@@ -138,13 +138,14 @@ class PageCyclerTypical25(_PageCycler):
options = {'pageset_repeat': 3}
@classmethod
- def ShouldDisable(cls, possible_browser): # http://crbug.com/597656
- if (possible_browser.browser_type == 'reference' and
- possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X'):
- return True
- # http://crbug.com/616781
+ def ShouldDisable(cls, possible_browser):
+ if possible_browser.browser_type == 'reference':
+ if possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X':
+ return True # http://crbug.com/597656
+ if possible_browser.platform.GetOSVersionName() == 'yosemite':
+ return True # http://crbug.com/634337
if possible_browser.platform.GetDeviceTypeName() == 'AOSP on BullHead':
- return True
+ return True # http://crbug.com/616781
return False
@classmethod
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698