Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/win/BUILD.gn

Issue 2214743002: Win/GN: Make no_exception config explicit. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix formatting Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/win/BUILD.gn
diff --git a/build/config/win/BUILD.gn b/build/config/win/BUILD.gn
index 90be9952c799d796c16958800bcd5362b2d0a9e5..155a973f91cee5a842e0d71f35c5aaaec2a90319 100644
--- a/build/config/win/BUILD.gn
+++ b/build/config/win/BUILD.gn
@@ -156,6 +156,11 @@ config("vs_code_analysis") {
}
}
+# This should go in :runtime_library.
brettw 2016/08/04 22:28:25 This comment doesn't make sense to me.
+config("no_exceptions") {
+ defines = [ "_HAS_EXCEPTIONS=0" ]
+}
+
# This is included by reference in the //build/config/compiler:runtime_library
# config that is applied to all targets. It is here to separate out the logic
# that is Windows-only. Please see that target for advice on what should go in
@@ -168,7 +173,6 @@ config("runtime_library") {
"__STD_C",
"_CRT_RAND_S",
"_CRT_SECURE_NO_DEPRECATE",
- "_HAS_EXCEPTIONS=0",
"_SCL_SECURE_NO_DEPRECATE",
]
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698