Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 2214633002: Use checkerboard pattern as the background of Quick View images. (Closed)

Created:
4 years, 4 months ago by oka
Modified:
4 years, 4 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, tienchang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use checkerboard pattern as the background of Quick View images. I copied CSS used in Google Images. http://goo.gl/0lPSZG BUG=633800 TEST=manually. See https://bugs.chromium.org/p/chromium/issues/detail?id=633800#c2 Committed: https://crrev.com/57368c7c6f03ed810ebd32960b49eafcf5de7621 Cr-Commit-Position: refs/heads/master@{#410914}

Patch Set 1 #

Total comments: 4

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M ui/file_manager/file_manager/foreground/elements/files_safe_img_webview_content.css View 1 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
oka
PTAL.
4 years, 4 months ago (2016-08-04 09:03:22 UTC) #3
fukino
lgtm with nits, assuming that the designer agreed on the visual. https://codereview.chromium.org/2214633002/diff/1/ui/file_manager/file_manager/foreground/elements/files_safe_img_webview_content.css File ui/file_manager/file_manager/foreground/elements/files_safe_img_webview_content.css (right): ...
4 years, 4 months ago (2016-08-04 09:08:43 UTC) #4
oka
nit
4 years, 4 months ago (2016-08-04 09:19:51 UTC) #6
oka
OK. I'll wait for Tien's LGTM. https://codereview.chromium.org/2214633002/diff/1/ui/file_manager/file_manager/foreground/elements/files_safe_img_webview_content.css File ui/file_manager/file_manager/foreground/elements/files_safe_img_webview_content.css (right): https://codereview.chromium.org/2214633002/diff/1/ui/file_manager/file_manager/foreground/elements/files_safe_img_webview_content.css#newcode24 ui/file_manager/file_manager/foreground/elements/files_safe_img_webview_content.css:24: background-position:0 0, 10px ...
4 years, 4 months ago (2016-08-04 09:20:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2214633002/20001
4 years, 4 months ago (2016-08-10 00:53:17 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-10 01:45:14 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 01:47:14 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/57368c7c6f03ed810ebd32960b49eafcf5de7621
Cr-Commit-Position: refs/heads/master@{#410914}

Powered by Google App Engine
This is Rietveld 408576698