Use checkerboard pattern as the background of Quick View images.

Use checkerboard pattern as the background of Quick View images.

I copied CSS used in Google Images. http://goo.gl/0lPSZG

BUG=633800
TEST=manually. See https://bugs.chromium.org/p/chromium/issues/detail?id=633800#c2

Committed: https://crrev.com/57368c7c6f03ed810ebd32960b49eafcf5de7621
Cr-Commit-Position: refs/heads/master@{#410914}

[oka, 2016-08-04 09:03:14]

Description was changed from

==========
Use checkerboard pattern as the background of Quick View images.

I copied CSS using in Google Images. http://goo.gl/0lPSZG

BUG=633800
==========

to

==========
Use checkerboard pattern as the background of Quick View images.

I copied CSS using in Google Images. http://goo.gl/0lPSZG

BUG=633800
TEST=manually. See
https://bugs.chromium.org/p/chromium/issues/detail?id=633800#c2
==========

[oka, 2016-08-04 09:03:14]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[oka, 2016-08-04 09:03:22]

PTAL.

[fukino, 2016-08-04 09:08:43]

lgtm with nits, assuming that the designer agreed on the visual.

https://codereview.chromium.org/2214633002/diff/1/ui/file_manager/file_manage...
File
ui/file_manager/file_manager/foreground/elements/files_safe_img_webview_content.css
(right):

https://codereview.chromium.org/2214633002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/elements/files_safe_img_webview_content.css:24:
background-position:0 0, 10px 10px;
A space needed after ':'

https://codereview.chromium.org/2214633002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/elements/files_safe_img_webview_content.css:25:
background-size:21px 21px;
ditto

[oka, 2016-08-04 09:16:35]

Description was changed from

==========
Use checkerboard pattern as the background of Quick View images.

I copied CSS using in Google Images. http://goo.gl/0lPSZG

BUG=633800
TEST=manually. See
https://bugs.chromium.org/p/chromium/issues/detail?id=633800#c2
==========

to

==========
Use checkerboard pattern as the background of Quick View images.

I copied CSS used in Google Images. http://goo.gl/0lPSZG

BUG=633800
TEST=manually. See
https://bugs.chromium.org/p/chromium/issues/detail?id=633800#c2
==========

[oka, 2016-08-04 09:19:51]

nit

[oka, 2016-08-04 09:20:46]

OK. I'll wait for Tien's LGTM.

https://codereview.chromium.org/2214633002/diff/1/ui/file_manager/file_manage...
File
ui/file_manager/file_manager/foreground/elements/files_safe_img_webview_content.css
(right):

https://codereview.chromium.org/2214633002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/elements/files_safe_img_webview_content.css:24:
background-position:0 0, 10px 10px;
On 2016/08/04 09:08:43, fukino wrote:
> A space needed after ':'

Done.

https://codereview.chromium.org/2214633002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/elements/files_safe_img_webview_content.css:25:
background-size:21px 21px;
On 2016/08/04 09:08:43, fukino wrote:
> ditto

Done.

[oka, 2016-08-10 00:52:26]

The CQ bit was checked by oka@chromium.org

[oka, 2016-08-10 00:52:27]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2214633002/#ps20001
(title: "nit")

[commit-bot: I haz the power, 2016-08-10 00:53:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 01:45:14]

Description was changed from

==========
Use checkerboard pattern as the background of Quick View images.

I copied CSS used in Google Images. http://goo.gl/0lPSZG

BUG=633800
TEST=manually. See
https://bugs.chromium.org/p/chromium/issues/detail?id=633800#c2
==========

to

==========
Use checkerboard pattern as the background of Quick View images.

I copied CSS used in Google Images. http://goo.gl/0lPSZG

BUG=633800
TEST=manually. See
https://bugs.chromium.org/p/chromium/issues/detail?id=633800#c2
==========

[commit-bot: I haz the power, 2016-08-10 01:45:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-10 01:47:13]

Description was changed from

==========
Use checkerboard pattern as the background of Quick View images.

I copied CSS used in Google Images. http://goo.gl/0lPSZG

BUG=633800
TEST=manually. See
https://bugs.chromium.org/p/chromium/issues/detail?id=633800#c2
==========

to

==========
Use checkerboard pattern as the background of Quick View images.

I copied CSS used in Google Images. http://goo.gl/0lPSZG

BUG=633800
TEST=manually. See
https://bugs.chromium.org/p/chromium/issues/detail?id=633800#c2

Committed: https://crrev.com/57368c7c6f03ed810ebd32960b49eafcf5de7621
Cr-Commit-Position: refs/heads/master@{#410914}
==========

[commit-bot: I haz the power, 2016-08-10 01:47:14]

Patchset 2 (id:??) landed as
https://crrev.com/57368c7c6f03ed810ebd32960b49eafcf5de7621
Cr-Commit-Position: refs/heads/master@{#410914}