Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 221463005: Enable use_mojo on mac (Closed)

Created:
6 years, 8 months ago by DaveMoore
Modified:
6 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
DaveMoore
Merge
6 years, 8 months ago (2014-04-01 22:07:29 UTC) #1
DaveMoore
It looks like it all just works on mac. I also tested w/ component=shared_library in ...
6 years, 8 months ago (2014-04-02 17:20:32 UTC) #2
sky
Awesome! LGTM
6 years, 8 months ago (2014-04-02 17:27:52 UTC) #3
DaveMoore
The CQ bit was checked by davemoore@chromium.org
6 years, 8 months ago (2014-04-02 17:34:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/221463005/20001
6 years, 8 months ago (2014-04-02 17:34:21 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 17:40:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 8 months ago (2014-04-02 17:41:00 UTC) #7
DaveMoore
6 years, 8 months ago (2014-04-02 22:27:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r261202 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698