Issue 221463004: Remove some checks from SharedStyleFinder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 221463004: Remove some checks from SharedStyleFinder (Closed)

Created:
6 years, 8 months ago by esprehn

Modified:
6 years, 8 months ago

Reviewers:
leviw_travelin_and_unemployed, ojan

CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove some checks from SharedStyleFinder Element::supportsStyleSharing() always returns false for elements that are hovered, focused or active or are the :target so we don't need to check those in the SharedStyleFinder. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170613

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -8 lines)			Patch
	M	Source/core/css/resolver/SharedStyleFinder.cpp	View		1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/221463004/1

6 years, 8 months ago (2014-04-01 23:15:36 UTC) #5

Message was sent while issue was closed.

Change committed as 170613

Expand Messages | Collapse Messages