Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2214613003: Convert server and cli and deprecate the old implementation (Closed)

Created:
4 years, 4 months ago by Brian Wilkerson
Modified:
4 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Convert server and cli and deprecate the old implementation R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/5b26441dbf745c0684ebf7d80429ff0b4c793cd9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -26 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 6 chunks +18 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/status/get_handler.dart View 7 chunks +7 lines, -1 line 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/source/embedder.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/sdk/sdk_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 10 chunks +18 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 4 months ago (2016-08-04 18:13:09 UTC) #2
scheglov
LGTM
4 years, 4 months ago (2016-08-04 18:19:07 UTC) #3
Brian Wilkerson
4 years, 4 months ago (2016-08-04 18:28:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5b26441dbf745c0684ebf7d80429ff0b4c793cd9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698