Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2214543003: Fix libpng build for ARM. (Closed)

Created:
4 years, 4 months ago by Lei Zhang
Modified:
4 years, 4 months ago
Reviewers:
msarett
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/BUILD.gn View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 10 (6 generated)
Lei Zhang
TBR This is blocking a DEPS roll: https://codereview.chromium.org/2214593002/ https://codereview.chromium.org/2214543003/diff/1/third_party/BUILD.gn File third_party/BUILD.gn (right): https://codereview.chromium.org/2214543003/diff/1/third_party/BUILD.gn#newcode353 third_party/BUILD.gn:353: } ...
4 years, 4 months ago (2016-08-04 07:19:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2214543003/1
4 years, 4 months ago (2016-08-04 07:19:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/a72ab5e0908ca29cfda91b3037da9b74cb06b93f
4 years, 4 months ago (2016-08-04 07:20:14 UTC) #9
msarett
4 years, 4 months ago (2016-08-04 12:56:21 UTC) #10
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698