Issue 22145005: Refactor code for <img> size calculation during attach

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22145005: Refactor code for <img> size calculation during attach (Closed)

Created:
7 years, 4 months ago by spartha

Modified:
7 years, 4 months ago

Reviewers:
esprehn, eseidel

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Refactor code for <img> size calculation during attach Based on the changes in revision 155294, the call to setImageSizeForAltText was being done twice when the "src" changed between non-empty URL to a empty one . First by RenderImageResource::setCachedImage and then follwed by a explicit call to setImageSizeForAltText in attach. Added checks to avoid unnecessary call to setImageSizeForAltText. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155583

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	Source/core/html/HTMLImageElement.cpp	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

spartha

Refactored the code to avoid additional call to setImageSizeForAltText. Please review the changes. Thanks!

7 years, 4 months ago (2013-08-05 14:37:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/22145005/1

7 years, 4 months ago (2013-08-06 05:04:50 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/22145005/1

7 years, 4 months ago (2013-08-06 05:47:42 UTC) #4

Message was sent while issue was closed.

Change committed as 155583

Expand Messages | Collapse Messages