Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2214483002: [LayoutNG] Change size members on NGConstraintSpace (Closed)

Created:
4 years, 4 months ago by eae
Modified:
4 years, 4 months ago
Reviewers:
ikilpatrick
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Change size members on NGConstraintSpace Update the NGConstraintSpace class to clarify naming and description of the various size members and methods. BUG=591099 R=ikilpatrick@chromium.org Committed: https://crrev.com/98af4a7f6e0cb62818f95c5e37818eb4d447f681 Cr-Commit-Position: refs/heads/master@{#409824}

Patch Set 1 #

Patch Set 2 : Remove out of date comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -35 lines) Patch
M third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h View 1 3 chunks +41 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.cpp View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
ikilpatrick
lgtm yeah looks, great; we'll probably want to revise derived constraint spaces once we've thought ...
4 years, 4 months ago (2016-08-03 22:53:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2214483002/20001
4 years, 4 months ago (2016-08-04 17:36:46 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-04 17:41:58 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 17:45:10 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/98af4a7f6e0cb62818f95c5e37818eb4d447f681
Cr-Commit-Position: refs/heads/master@{#409824}

Powered by Google App Engine
This is Rietveld 408576698