Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2214453002: Update BUILD.gn template (Closed)

Created:
4 years, 4 months ago by xyzzyz
Modified:
4 years, 3 months ago
Reviewers:
Garrett Casto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/external/github.com/grpc/grpc@2016-07-27
Target Ref:
refs/heads/chromium-deps/2016-07-27
Visibility:
Public.

Description

Update gRPC's BUILD.gn template to fix the public_configs, and targets dependencies. BUG=618889 R=gcasto@chromium.org Committed: https://chromium.googlesource.com/external/github.com/grpc/grpc/+/3334ae71dca1c60ede931898ebee002f001ab755

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix grpc++_unsecure deps #

Total comments: 2

Patch Set 3 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -40 lines) Patch
M BUILD.gn View 1 2 8 chunks +38 lines, -26 lines 0 comments Download
M templates/BUILD.gn.template View 1 2 5 chunks +21 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Garrett Casto
https://codereview.chromium.org/2214453002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2214453002/diff/1/BUILD.gn#newcode15 BUILD.gn:15: config("grpc_no_cxx11_threads") { Is there any reason why this is ...
4 years, 4 months ago (2016-08-15 21:20:59 UTC) #3
xyzzyz
https://codereview.chromium.org/2214453002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2214453002/diff/1/BUILD.gn#newcode15 BUILD.gn:15: config("grpc_no_cxx11_threads") { On 2016/08/15 21:20:59, Garrett Casto wrote: > ...
4 years, 4 months ago (2016-08-15 21:59:20 UTC) #5
Garrett Casto
LGTM https://codereview.chromium.org/2214453002/diff/20001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2214453002/diff/20001/BUILD.gn#newcode16 BUILD.gn:16: # Therefore, we need to make gRPC not ...
4 years, 4 months ago (2016-08-15 22:43:17 UTC) #6
xyzzyz
4 years, 4 months ago (2016-08-15 23:10:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
3334ae71dca1c60ede931898ebee002f001ab755 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698