Change network error titles to just the hostname

chrome/browser/policy/policy_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
 #include <memory>
 #include <string>
@@ skipping 353 matching lines @@
 };
 
 // Verifies that the given url |spec| can be opened. This assumes that |spec|
 // points at empty.html in the test data dir.
 void CheckCanOpenURL(Browser* browser, const char* spec) {
   GURL url(spec);
   ui_test_utils::NavigateToURL(browser, url);
   content::WebContents* contents =
       browser->tab_strip_model()->GetActiveWebContents();
   EXPECT_EQ(url, contents->GetURL());
-  base::string16 spec16 = base::UTF8ToUTF16(url.spec());
-  base::string16 title =
-      l10n_util::GetStringFUTF16(IDS_ERRORPAGES_TITLE_BLOCKED, spec16);
+
+  base::string16 title;

[Thiemo Nagel, 2016/08/09 18:24:58]

To make this more understandable, could you maybe explain that |title| contains
the page title for the blocked page?  And/or maybe rename to
|blocked_page_title| or |title_if_blocked| or something similar?

+  if (url.has_host()) {
+    title = base::UTF8ToUTF16(url.host());
+  } else {
+    //  Local file paths show the full URL.

[Thiemo Nagel, 2016/08/09 18:24:57]

Nit: Please drop duplicate blank.

+    title = base::UTF8ToUTF16(url.spec());
+  }
   EXPECT_NE(title, contents->GetTitle());
 }
 
 // Verifies that access to the given url |spec| is blocked.
 void CheckURLIsBlocked(Browser* browser, const char* spec) {
   GURL url(spec);
   ui_test_utils::NavigateToURL(browser, url);
   content::WebContents* contents =
       browser->tab_strip_model()->GetActiveWebContents();
   EXPECT_EQ(url, contents->GetURL());
-  base::string16 spec16 = base::UTF8ToUTF16(url.spec());
-  base::string16 title =
-      l10n_util::GetStringFUTF16(IDS_ERRORPAGES_TITLE_BLOCKED, spec16);
+
+  base::string16 title;

[Thiemo Nagel, 2016/08/09 18:24:57]

Same as above.

+  if (url.has_host()) {
+    title = base::UTF8ToUTF16(url.host());
+  } else {
+    //  Local file paths show the full URL.

[Thiemo Nagel, 2016/08/09 18:24:58]

Nit: Please drop duplicate blank.

+    title = base::UTF8ToUTF16(url.spec());
+  }
   EXPECT_EQ(title, contents->GetTitle());
 
   // Verify that the expected error page is being displayed.
   bool result = false;
   EXPECT_TRUE(content::ExecuteScriptAndExtractBool(
       contents,
       "var textContent = document.body.textContent;"
       "var hasError = textContent.indexOf('ERR_BLOCKED_BY_ADMINISTRATOR') >= 0;"
       "domAutomationController.send(hasError);",
       &result));
@@ skipping 3723 matching lines @@
 
   SetEmptyPolicy();
   // Policy not set.
   CheckSystemTimezoneAutomaticDetectionPolicyUnset();
   EXPECT_TRUE(CheckResolveTimezoneByGeolocation(true, false));
   EXPECT_TRUE(manager->TimeZoneResolverShouldBeRunningForTests());
 }
 #endif  // defined(OS_CHROMEOS)
 
 }  // namespace policy