Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2214373003: Include changelog in script-generated roll CLs of WebRTC in Chromium (Closed)

Created:
4 years, 4 months ago by ehmaldonado_chromium
Modified:
4 years, 4 months ago
CC:
chromium-reviews, Niklas Enbom
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include changelog in script-generated roll CLs of WebRTC in Chromium It's useful to have when looking for offending CLs. Example (third_party/chromite): https://chromium.googlesource.com/chromium/src.git/+/2a6c585c5a6ae79954208952a5e03763332dbf8d Example (generated by tools/roll_webrtc.py after this CL): https://codereview.chromium.org/2221453002/ BUG=634466 Committed: https://crrev.com/09deeb015e05d59a4b6673250f66b8ed172c1065 Cr-Commit-Position: refs/heads/master@{#410045}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -20 lines) Patch
M tools/roll_webrtc.py View 3 chunks +34 lines, -20 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
ehmaldonado_chromium
4 years, 4 months ago (2016-08-05 12:01:45 UTC) #3
kjellander_chromium
+cc niklase FYI This looks great, lgtm!
4 years, 4 months ago (2016-08-05 12:54:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2214373003/1
4 years, 4 months ago (2016-08-05 12:57:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2214373003/1
4 years, 4 months ago (2016-08-05 12:58:37 UTC) #9
ehmaldonado_chromium
On 2016/08/05 12:58:37, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 4 months ago (2016-08-05 12:59:55 UTC) #10
kjellander_chromium
On 2016/08/05 12:59:55, ehmaldonado_chromium wrote: > On 2016/08/05 12:58:37, commit-bot: I haz the power wrote: ...
4 years, 4 months ago (2016-08-05 13:02:13 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 13:32:28 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 13:33:33 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09deeb015e05d59a4b6673250f66b8ed172c1065
Cr-Commit-Position: refs/heads/master@{#410045}

Powered by Google App Engine
This is Rietveld 408576698