Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2214373002: fix position of bubble in gallery to consider RTL (Closed)

Created:
4 years, 4 months ago by harukam
Modified:
4 years, 4 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

fix position of bubble in gallery to consider RTL BUG=617543 TEST=manually tested Committed: https://crrev.com/bcf4cd476fedcbb9879fb7694600ae2829f20f70 Cr-Commit-Position: refs/heads/master@{#410554}

Patch Set 1 #

Patch Set 2 : fix position of bubble in gallary #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M ui/file_manager/gallery/css/gallery.css View 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
harukam
PTAL
4 years, 4 months ago (2016-08-05 02:13:50 UTC) #2
harukam
PTAL
4 years, 4 months ago (2016-08-05 02:15:24 UTC) #5
fukino
lgtm. Thanks!
4 years, 4 months ago (2016-08-09 01:10:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2214373002/1
4 years, 4 months ago (2016-08-09 02:18:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 02:53:09 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 02:54:41 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bcf4cd476fedcbb9879fb7694600ae2829f20f70
Cr-Commit-Position: refs/heads/master@{#410554}

Powered by Google App Engine
This is Rietveld 408576698