Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2214343002: MD Settings: Display: Fix overscan dialog for <dialog> (Closed)

Created:
4 years, 4 months ago by stevenjb
Modified:
4 years, 4 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Display: Fix overscan dialog for <dialog> BUG=625332 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/2ae3d13515f1ca46261eda7264edd2e9293a8b80 Cr-Commit-Position: refs/heads/master@{#409972}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/device_page/display_overscan_dialog.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
stevenjb
4 years, 4 months ago (2016-08-05 01:31:39 UTC) #3
dpapad
Let's link this to crbug.com/625332. LGTM.
4 years, 4 months ago (2016-08-05 01:35:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2214343002/1
4 years, 4 months ago (2016-08-05 01:39:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 02:37:24 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 02:38:41 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ae3d13515f1ca46261eda7264edd2e9293a8b80
Cr-Commit-Position: refs/heads/master@{#409972}

Powered by Google App Engine
This is Rietveld 408576698