Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2214323003: Revert of Disable Print in the context menu when a modal dialog is shown (Closed)

Created:
4 years, 4 months ago by takumif
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable Print in the context menu when a modal dialog is shown (patchset #3 id:40001 of https://codereview.chromium.org/2215123002/ ) Reason for revert: chrome::FindBrowserWithWebContents(source_web_contents_) returns a nullptr for the PDF viewer, causing the Print option to be disabled for PDFs. We need to replace chrome::FindBrowserWithWebContents(source_web_contents_). Original issue's description: > Disable Print in the context menu when a modal dialog is shown > > Disable the "Print..." option in the page context menu when chrome::CanPrint > is false. This disables printing when a modal dialog, such as the Media Router > dialog, is being shown, just like the Print option in the hotdog menu. > > BUG=590650 > > Committed: https://crrev.com/10d41a7cb5416afdb434e98c3b411284c0ab0be8 > Cr-Commit-Position: refs/heads/master@{#410138} TBR=thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=590650 Committed: https://crrev.com/a89a3fe84309645f6cbf9d745bbd66a80853ffba Cr-Commit-Position: refs/heads/master@{#410146}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M chrome/browser/renderer_context_menu/render_view_context_menu.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 2 chunks +3 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
takumif
Created Revert of Disable Print in the context menu when a modal dialog is shown
4 years, 4 months ago (2016-08-05 19:28:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2214323003/1
4 years, 4 months ago (2016-08-05 19:28:37 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-05 19:28:39 UTC) #5
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-05 19:37:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2214323003/1
4 years, 4 months ago (2016-08-05 19:37:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 19:39:16 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 19:40:48 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a89a3fe84309645f6cbf9d745bbd66a80853ffba
Cr-Commit-Position: refs/heads/master@{#410146}

Powered by Google App Engine
This is Rietveld 408576698