Add a Java InterfaceRegistry.

Add a Java InterfaceRegistry.

This also removes the old Java mojo application support, which has
rotted.

BUG=634568, 637174
Committed: https://crrev.com/13e14e9347cc0ae289c2b339876acea544859675
Cr-Commit-Position: refs/heads/master@{#411550}

[Sam McNally, 2016-08-05 01:22:13]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 01:22:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 03:31:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 03:31:44]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-08-05 04:45:57]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 04:46:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-08-05 05:00:50]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2016-08-05 05:06:21]

sammc@chromium.org changed reviewers:
+ ben@chromium.org

[commit-bot: I haz the power, 2016-08-05 05:26:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 05:26:44]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ben Goodger (Google), 2016-08-05 05:32:00]

should probably also be in chromium/services/shell instead of chromium/shell

https://codereview.chromium.org/2214323002/diff/20001/services/shell/public/j...
File services/shell/public/java/src/org/chromium/shell/InterfaceRegistry.java
(right):

https://codereview.chromium.org/2214323002/diff/20001/services/shell/public/j...
services/shell/public/java/src/org/chromium/shell/InterfaceRegistry.java:16:
public interface InterfaceRegistry {
I'm not a java expert, what's the reason to use an interface vs. just have a
single concrete InterfaceRegistry class?

[Sam McNally, 2016-08-05 06:06:38]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 06:07:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-08-05 06:16:56]

On 2016/08/05 05:32:00, Ben Goodger (Google) wrote:
> should probably also be in chromium/services/shell instead of chromium/shell

Done.

https://codereview.chromium.org/2214323002/diff/20001/services/shell/public/j...
File services/shell/public/java/src/org/chromium/shell/InterfaceRegistry.java
(right):

https://codereview.chromium.org/2214323002/diff/20001/services/shell/public/j...
services/shell/public/java/src/org/chromium/shell/InterfaceRegistry.java:16:
public interface InterfaceRegistry {
On 2016/08/05 05:32:00, Ben Goodger (Google) wrote:
> I'm not a java expert, what's the reason to use an interface vs. just have a
> single concrete InterfaceRegistry class?

Just the usual sorts of reasons: it avoids leaking the methods that are public
in the impl because it implements the InterfaceProvider interface:
getInterface(), close() and onConnectionError(), and provides greater
flexibility in mocking/faking/etc. in tests.

[commit-bot: I haz the power, 2016-08-05 07:36:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 07:36:43]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Sam McNally, 2016-08-10 05:42:35]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 05:43:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-08-10 05:43:41]

Patchset #3 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-08-10 05:44:55]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sam McNally, 2016-08-10 05:46:00]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 05:46:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-08-10 05:52:58]

https://codereview.chromium.org/2214323002/diff/20001/services/shell/public/j...
File services/shell/public/java/src/org/chromium/shell/InterfaceRegistry.java
(right):

https://codereview.chromium.org/2214323002/diff/20001/services/shell/public/j...
services/shell/public/java/src/org/chromium/shell/InterfaceRegistry.java:16:
public interface InterfaceRegistry {
On 2016/08/05 06:16:56, Sam McNally wrote:
> On 2016/08/05 05:32:00, Ben Goodger (Google) wrote:
> > I'm not a java expert, what's the reason to use an interface vs. just have a
> > single concrete InterfaceRegistry class?
> 
> Just the usual sorts of reasons: it avoids leaking the methods that are public
> in the impl because it implements the InterfaceProvider interface:
> getInterface(), close() and onConnectionError(), and provides greater
> flexibility in mocking/faking/etc. in tests.

On the other hand, using just an InterfaceRegistry class does avoid a fair
amount of boilerplate. We can always add an interface later.

[Ben Goodger (Google), 2016-08-10 05:54:22]

On 2016/08/10 05:52:58, Sam McNally wrote:
>
https://codereview.chromium.org/2214323002/diff/20001/services/shell/public/j...
> File services/shell/public/java/src/org/chromium/shell/InterfaceRegistry.java
> (right):
> 
>
https://codereview.chromium.org/2214323002/diff/20001/services/shell/public/j...
> services/shell/public/java/src/org/chromium/shell/InterfaceRegistry.java:16:
> public interface InterfaceRegistry {
> On 2016/08/05 06:16:56, Sam McNally wrote:
> > On 2016/08/05 05:32:00, Ben Goodger (Google) wrote:
> > > I'm not a java expert, what's the reason to use an interface vs. just have
a
> > > single concrete InterfaceRegistry class?
> > 
> > Just the usual sorts of reasons: it avoids leaking the methods that are
public
> > in the impl because it implements the InterfaceProvider interface:
> > getInterface(), close() and onConnectionError(), and provides greater
> > flexibility in mocking/faking/etc. in tests.
> 
> On the other hand, using just an InterfaceRegistry class does avoid a fair
> amount of boilerplate. We can always add an interface later.

ok...

[commit-bot: I haz the power, 2016-08-10 07:14:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 07:14:25]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-08-12 01:09:55]

On 2016/08/10 05:54:22, Ben Goodger (Google) wrote:
> On 2016/08/10 05:52:58, Sam McNally wrote:
> >
>
https://codereview.chromium.org/2214323002/diff/20001/services/shell/public/j...
> > File
services/shell/public/java/src/org/chromium/shell/InterfaceRegistry.java
> > (right):
> > 
> >
>
https://codereview.chromium.org/2214323002/diff/20001/services/shell/public/j...
> > services/shell/public/java/src/org/chromium/shell/InterfaceRegistry.java:16:
> > public interface InterfaceRegistry {
> > On 2016/08/05 06:16:56, Sam McNally wrote:
> > > On 2016/08/05 05:32:00, Ben Goodger (Google) wrote:
> > > > I'm not a java expert, what's the reason to use an interface vs. just
have
> a
> > > > single concrete InterfaceRegistry class?
> > > 
> > > Just the usual sorts of reasons: it avoids leaking the methods that are
> public
> > > in the impl because it implements the InterfaceProvider interface:
> > > getInterface(), close() and onConnectionError(), and provides greater
> > > flexibility in mocking/faking/etc. in tests.
> > 
> > On the other hand, using just an InterfaceRegistry class does avoid a fair
> > amount of boilerplate. We can always add an interface later.
> 
> ok...

Did you have any other comments on this CL?

[Ben Goodger (Google), 2016-08-12 01:54:24]

sorry got lost in the shuffle while I was OOO.

lgtm.

do you anticipate replacing
https://chromium.googlesource.com/chromium/src/+/master/content/public/androi...
with this? if so can you file a bug to do so?

[Sam McNally, 2016-08-12 03:16:46]

Description was changed from

==========
Add a Java InterfaceRegistry.

This also removes the old Java mojo application support, which has
rotted.

BUG=634568
==========

to

==========
Add a Java InterfaceRegistry.

This also removes the old Java mojo application support, which has
rotted.

BUG=634568,637174
==========

[Sam McNally, 2016-08-12 03:25:29]

On 2016/08/12 01:54:24, Ben Goodger (Google) wrote:
> sorry got lost in the shuffle while I was OOO.
> 
> lgtm.
> 
> do you anticipate replacing
>
https://chromium.googlesource.com/chromium/src/+/master/content/public/androi...
> with this? if so can you file a bug to do so?

Yes. Filed https://crbug.com/637174.

[Sam McNally, 2016-08-12 03:25:38]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2016-08-12 03:25:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 04:22:10]

Description was changed from

==========
Add a Java InterfaceRegistry.

This also removes the old Java mojo application support, which has
rotted.

BUG=634568,637174
==========

to

==========
Add a Java InterfaceRegistry.

This also removes the old Java mojo application support, which has
rotted.

BUG=634568,637174
==========

[commit-bot: I haz the power, 2016-08-12 04:22:11]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-08-12 04:24:05]

Description was changed from

==========
Add a Java InterfaceRegistry.

This also removes the old Java mojo application support, which has
rotted.

BUG=634568,637174
==========

to

==========
Add a Java InterfaceRegistry.

This also removes the old Java mojo application support, which has
rotted.

BUG=634568,637174

Committed: https://crrev.com/13e14e9347cc0ae289c2b339876acea544859675
Cr-Commit-Position: refs/heads/master@{#411550}
==========

[commit-bot: I haz the power, 2016-08-12 04:24:06]

Patchset 3 (id:??) landed as
https://crrev.com/13e14e9347cc0ae289c2b339876acea544859675
Cr-Commit-Position: refs/heads/master@{#411550}