Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2214293003: Revert of Remove usage of SSLStatus in RenderFrameImpl. (Closed)

Created:
4 years, 4 months ago by jam
Modified:
4 years, 4 months ago
Reviewers:
estark
CC:
chromium-reviews, nasko+codewatch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove usage of SSLStatus in RenderFrameImpl. (patchset #6 id:140001 of https://codereview.chromium.org/2191113002/ ) Reason for revert: Causing test flakiness. BUG=634543 Original issue's description: > Remove usage of SSLStatus in RenderFrameImpl. > > Per discussion, this optimization isn't necessary anymore since we don't have a UI that shows frame specific errors. > > BUG=598073 > > Committed: https://crrev.com/6ce51b7351ed32a0b6c82f5a83d83641a1b5babd > Cr-Commit-Position: refs/heads/master@{#409855} TBR=estark@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=598073 Committed: https://crrev.com/7aae8a212cb79e589dfc7328a6c03138b424a754 Cr-Commit-Position: refs/heads/master@{#409952}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -30 lines) Patch
M chrome/browser/ssl/ssl_browser_tests.cc View 7 chunks +20 lines, -26 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 3 chunks +52 lines, -3 lines 0 comments Download
M testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
jam
Created Revert of Remove usage of SSLStatus in RenderFrameImpl.
4 years, 4 months ago (2016-08-05 00:47:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2214293003/1
4 years, 4 months ago (2016-08-05 00:47:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 00:48:34 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 00:50:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7aae8a212cb79e589dfc7328a6c03138b424a754
Cr-Commit-Position: refs/heads/master@{#409952}

Powered by Google App Engine
This is Rietveld 408576698