[BlobStorage] Added back security policy for files in blobs

content/browser/blob_storage/blob_dispatcher_host.h

Index: content/browser/blob_storage/blob_dispatcher_host.h
diff --git a/content/browser/blob_storage/blob_dispatcher_host.h b/content/browser/blob_storage/blob_dispatcher_host.h
index b004aa2ab30aed8b7e9c8add3a2820337890c936..f2e23eaff5b3767747ce92f7f1ff6abb8227c61e 100644
--- a/content/browser/blob_storage/blob_dispatcher_host.h
+++ b/content/browser/blob_storage/blob_dispatcher_host.h
@@ -32,9 +32,11 @@ class BlobDataBuilder;
 struct BlobItemBytesRequest;
 struct BlobItemBytesResponse;
 class BlobStorageContext;
+class FileSystemContext;
 }
 
 namespace content {
+class ChildProcessSecurityPolicyImpl;
 class ChromeBlobStorageContext;
 
 // This class's responsibility is to listen for and dispatch blob storage
@@ -45,7 +47,9 @@ class ChromeBlobStorageContext;
 // is one per child process.
 class CONTENT_EXPORT BlobDispatcherHost : public BrowserMessageFilter {
  public:
-  explicit BlobDispatcherHost(ChromeBlobStorageContext* blob_storage_context);
+  BlobDispatcherHost(int process_id,
+                     storage::FileSystemContext* file_system_context,
+                     ChromeBlobStorageContext* blob_storage_context);

[kinuko, 2016/08/05 15:27:31]

nit: I'd place file_system_context parameter after blob_storage_context

[dmurph, 2016/08/05 19:12:45]

Done.

 
   // BrowserMessageFilter implementation.
   void OnChannelClosing() override;
@@ -132,6 +136,10 @@ class CONTENT_EXPORT BlobDispatcherHost : public BrowserMessageFilter {
   // Unregisters all blobs and urls that were registered in this host.
   void ClearHostFromBlobStorageContext();
 
+  int process_id_;

[kinuko, 2016/08/05 15:27:31]

const

[dmurph, 2016/08/05 19:12:45]

Done.

+  storage::FileSystemContext* file_system_context_;

[kinuko, 2016/08/05 15:27:31]

nit: I think this'd be safe, but maybe we'd better store this as scoped_refptr?

[dmurph, 2016/08/05 19:12:45]

The FileApiMessageFilter just stores the raw pointer... is it alright if we keep
it a raw pointer? I'm not sure if I'll be introducing a refcount cycle if I make
it a scoped_refptr

[kinuko, 2016/08/08 15:52:28]

Either works for me as far as we don't crash/leak, but it looked a bit weird /
inconsistent to me as we hold blob_storage_context_ as a ref-ptr while
file_system_context_ as a raw-ptr.

[dmurph, 2016/08/15 18:25:04]

Done.

+  ChildProcessSecurityPolicyImpl* security_policy_;
+
   // Collection of blob ids and a count of how many usages
   // of that id are attributable to this consumer.
   BlobReferenceMap blobs_inuse_map_;