Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2214283003: [test] Activate ignition_staging variant (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Activate ignition_staging variant BUG=v8:5238 NOTREECHECKS=true Committed: https://crrev.com/55a4344f41a478a2524abee44a45c6f9a59020b4 Cr-Commit-Position: refs/heads/master@{#38381}

Patch Set 1 #

Patch Set 2 : [test] Activate ignition_staging variant #

Patch Set 3 : status #

Patch Set 4 : More status #

Patch Set 5 : Fixes #

Patch Set 6 : Skip one cpu profiler test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -4 lines) Patch
M test/cctest/cctest.status View 1 2 3 4 5 1 chunk +48 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 4 5 1 chunk +46 lines, -0 lines 0 comments Download
M tools/run-tests.py View 1 1 chunk +1 line, -2 lines 0 comments Download
M tools/testrunner/local/variants.py View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 29 (23 generated)
Michael Achenbach
PTAL. If there are more test failures I will reiterate modifying the status files until ...
4 years, 4 months ago (2016-08-05 10:51:19 UTC) #15
Michael Starzinger
LGTM from my side. Awesome. Thanks!
4 years, 4 months ago (2016-08-05 10:54:09 UTC) #16
rmcilroy
LGTM, thanks!
4 years, 4 months ago (2016-08-05 12:02:54 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2214283003/80001
4 years, 4 months ago (2016-08-05 12:44:49 UTC) #25
commit-bot: I haz the power
Committed patchset #6 (id:80001)
4 years, 4 months ago (2016-08-05 12:46:55 UTC) #27
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 12:48:45 UTC) #29
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/55a4344f41a478a2524abee44a45c6f9a59020b4
Cr-Commit-Position: refs/heads/master@{#38381}

Powered by Google App Engine
This is Rietveld 408576698