Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2214263006: arc: bluetooth: Fix LSAN error in fake_bluetooth_instance (Closed)

Created:
4 years, 4 months ago by puthik_chromium
Modified:
4 years, 4 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org, rkc
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: bluetooth: Fix LSAN error in fake_bluetooth_instance fake_bluetooth_instance used raw pointer to store all the requests to mojo BluetoothInstance. However, this can easisly caused memory leak unless we are carefully delete those data. This CL changes it to std::unique_ptr<> to auto destroy those data when fake_bluetooth_instance is destroyed. BUG=634898 TEST=Run tests with ASAN and LSAN Committed: https://crrev.com/dea5e4beeecc2dac9ec84dd30741a24d2214795f Cr-Commit-Position: refs/heads/master@{#410160}

Patch Set 1 #

Patch Set 2 : Add #include <memory> for unique_ptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M components/arc/test/fake_bluetooth_instance.h View 1 2 chunks +6 lines, -4 lines 0 comments Download
M components/arc/test/fake_bluetooth_instance.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
puthik_chromium
4 years, 4 months ago (2016-08-05 18:50:19 UTC) #2
Reilly Grant (use Gerrit)
lgtm Please land this patch as soon as possible. The tree should not be left ...
4 years, 4 months ago (2016-08-05 19:30:53 UTC) #6
puthik_chromium
+Owner Look like lhchavez@ is OoO today.
4 years, 4 months ago (2016-08-05 20:22:52 UTC) #8
elijahtaylor1
lgtm
4 years, 4 months ago (2016-08-05 20:31:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2214263006/20001
4 years, 4 months ago (2016-08-05 20:33:24 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-05 21:09:08 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 21:11:12 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dea5e4beeecc2dac9ec84dd30741a24d2214795f
Cr-Commit-Position: refs/heads/master@{#410160}

Powered by Google App Engine
This is Rietveld 408576698