Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2214263005: Mark recursive_inheritance_test as passing (Closed)

Created:
4 years, 4 months ago by vsm
Modified:
4 years, 4 months ago
Reviewers:
Leaf, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark recursive_inheritance_test as passing This will get the dev and master bots green. Will need to bump the pubspec on analyzer (once published) to make stable green after this. R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/fa084164b620ea75cd2008c9dc317655a045ad6d

Patch Set 1 #

Patch Set 2 : Bumped pubspec #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2346 lines, -1480 lines) Patch
M lib/runtime/dart_sdk.js View 1 4 chunks +4 lines, -4 lines 0 comments Download
M pubspec.lock View 1 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M test/browser/language_tests.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/codegen_expected/corelib/int_modulo_arith_test_bignum_multi.js View 1 2 chunks +3 lines, -2 lines 0 comments Download
M test/codegen_expected/corelib/int_modulo_arith_test_modPow_multi.js View 1 2 chunks +3 lines, -2 lines 0 comments Download
M test/codegen_expected/corelib/int_modulo_arith_test_none_multi.js View 1 2 chunks +3 lines, -2 lines 0 comments Download
M test/codegen_expected/corelib/set_test.js View 1 1 chunk +593 lines, -1 line 0 comments Download
M test/codegen_expected/corelib/string_fromcharcodes_test.js View 1 Binary file 0 comments Download
M test/codegen_expected/language/async_await_syntax_test_c01a_multi.js View 1 2 chunks +2 lines, -1 line 0 comments Download
M test/codegen_expected/language/async_await_syntax_test_c02a_multi.js View 1 2 chunks +2 lines, -1 line 0 comments Download
M test/codegen_expected/language/async_await_syntax_test_c03a_multi.js View 1 2 chunks +2 lines, -1 line 0 comments Download
M test/codegen_expected/language/async_await_syntax_test_c04a_multi.js View 1 2 chunks +2 lines, -1 line 0 comments Download
M test/codegen_expected/language/async_await_syntax_test_c05a_multi.js View 1 2 chunks +2 lines, -1 line 0 comments Download
M test/codegen_expected/language/async_await_syntax_test_c06a_multi.js View 1 2 chunks +2 lines, -1 line 0 comments Download
M test/codegen_expected/language/async_await_syntax_test_c07a_multi.js View 1 2 chunks +4 lines, -2 lines 0 comments Download
M test/codegen_expected/language/async_await_syntax_test_c08a_multi.js View 1 2 chunks +2 lines, -1 line 0 comments Download
M test/codegen_expected/language/async_await_syntax_test_c09a_multi.js View 1 2 chunks +4 lines, -2 lines 0 comments Download
M test/codegen_expected/language/async_star_await_pauses_test.js View 1 2 chunks +7 lines, -5 lines 0 comments Download
M test/codegen_expected/language/async_star_cancel_while_paused_test.js View 1 2 chunks +9 lines, -6 lines 0 comments Download
M test/codegen_expected/language/async_star_regression_2238_test.js View 1 2 chunks +10 lines, -6 lines 0 comments Download
M test/codegen_expected/language/async_star_regression_fisk_test.js View 1 3 chunks +7 lines, -5 lines 0 comments Download
M test/codegen_expected/language/async_star_stream_take_test.js View 1 2 chunks +7 lines, -6 lines 0 comments Download
M test/codegen_expected/language/async_star_take_reyield_test.js View 1 2 chunks +4 lines, -3 lines 0 comments Download
M test/codegen_expected/language/async_star_test_01_multi.js View 1 60 chunks +247 lines, -217 lines 0 comments Download
M test/codegen_expected/language/async_star_test_02_multi.js View 1 60 chunks +250 lines, -220 lines 0 comments Download
M test/codegen_expected/language/async_star_test_03_multi.js View 1 60 chunks +250 lines, -220 lines 0 comments Download
M test/codegen_expected/language/async_star_test_04_multi.js View 1 60 chunks +247 lines, -217 lines 0 comments Download
M test/codegen_expected/language/async_star_test_05_multi.js View 1 60 chunks +250 lines, -220 lines 0 comments Download
M test/codegen_expected/language/async_star_test_none_multi.js View 1 59 chunks +245 lines, -215 lines 0 comments Download
M test/codegen_expected/language/async_test.js View 1 3 chunks +8 lines, -6 lines 0 comments Download
M test/codegen_expected/language/bool_test.js View 1 2 chunks +3 lines, -2 lines 0 comments Download
M test/codegen_expected/language/call_closurization_test.js View 1 3 chunks +6 lines, -7 lines 0 comments Download
M test/codegen_expected/language/call_test.js View 1 3 chunks +6 lines, -7 lines 0 comments Download
M test/codegen_expected/language/cascade_precedence_test.js View 1 3 chunks +4 lines, -3 lines 0 comments Download
M test/codegen_expected/language/cha_deopt2_test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/codegen_expected/language/cha_deopt3_test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/codegen_expected/language/closure6_test.js View 1 1 chunk +4 lines, -2 lines 0 comments Download
M test/codegen_expected/language/closure_call_wrong_argument_count_negative_test.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M test/codegen_expected/language/closure_type_variable_test.js View 1 2 chunks +2 lines, -1 line 0 comments Download
M test/codegen_expected/language/closure_type_variables_test.js View 1 2 chunks +2 lines, -1 line 0 comments Download
M test/codegen_expected/language/compound_assignment_operator_test.js View 1 4 chunks +11 lines, -7 lines 0 comments Download
M test/codegen_expected/language/context_test.js View 1 2 chunks +2 lines, -1 line 0 comments Download
M test/codegen_expected/language/function_syntax_test_none_multi.js View 1 7 chunks +13 lines, -13 lines 0 comments Download
M test/codegen_expected/language/implicit_closure_test.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M test/codegen_expected/language/inlined_conditional_test.js View 1 2 chunks +2 lines, -1 line 0 comments Download
M test/codegen_expected/language/issue_22780_test_01_multi.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/codegen_expected/language/issue_23914_test.js View 1 1 chunk +2 lines, -4 lines 0 comments Download
M test/codegen_expected/language/local_function_non_equal_test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/codegen_expected/language/mint_arithmetic_test.js View 1 2 chunks +3 lines, -2 lines 0 comments Download
M test/codegen_expected/language/param2_test.js View 1 2 chunks +1 line, -2 lines 0 comments Download
M test/codegen_expected/language/range_analysis2_test.js View 1 1 chunk +3 lines, -2 lines 0 comments Download
M test/codegen_expected/language/recursive_inheritance_test.js View 1 1 chunk +48 lines, -1 line 0 comments Download
M test/codegen_expected/language/regress_21016_test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/codegen_expected/language/string_interpolate2_test.js View 1 3 chunks +3 lines, -3 lines 0 comments Download
M test/codegen_expected/language/syncstar_less_than_test.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/codegen_expected/language/type_propagation2_test.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/codegen_expected/lib/html/client_rect_test.js View 1 2 chunks +2 lines, -1 line 0 comments Download
M test/codegen_expected/lib/html/filteredelementlist_test.js View 1 2 chunks +29 lines, -28 lines 0 comments Download
M test/codegen_expected/lib/html/js_typed_interop_test.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M test/codegen_expected/lib/html/svg_test.js View 1 5 chunks +5 lines, -4 lines 0 comments Download
M test/codegen_expected/stack_trace/stack_trace.js View 1 2 chunks +4 lines, -3 lines 0 comments Download
M tool/sdk_expected_errors.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
vsm
4 years, 4 months ago (2016-08-05 16:27:01 UTC) #3
Leaf
lgtm
4 years, 4 months ago (2016-08-05 16:32:52 UTC) #5
vsm
Committed patchset #2 (id:20001) manually as fa084164b620ea75cd2008c9dc317655a045ad6d (presubmit successful).
4 years, 4 months ago (2016-08-05 16:35:13 UTC) #7
Jennifer Messerly
4 years, 4 months ago (2016-08-05 17:35:49 UTC) #8
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698