Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: pkg/compiler/lib/src/typechecker.dart

Issue 2214263002: delete send-info measurements. This experiment is not being maintained (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: also remove test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/info/trusted_types_analysis_result.dart ('k') | tests/compiler/dart2js/dart2js.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/typechecker.dart
diff --git a/pkg/compiler/lib/src/typechecker.dart b/pkg/compiler/lib/src/typechecker.dart
index be25edf0f08303263380249cc08cf712f9082e50..b4ad1f8c289959b0039c4b18d57fdce5f619d2d7 100644
--- a/pkg/compiler/lib/src/typechecker.dart
+++ b/pkg/compiler/lib/src/typechecker.dart
@@ -443,7 +443,7 @@ class TypeCheckerVisitor extends Visitor<DartType> {
if (result == null) {
reporter.internalError(node, 'Type is null.');
}
- return _record(node, result);
+ return result;
}
void checkTypePromotion(Node node, TypePromotion typePromotion,
@@ -1151,24 +1151,6 @@ class TypeCheckerVisitor extends Visitor<DartType> {
return null;
}
- static bool _fyiShown = false;
- DartType _record(Node node, DartType type) {
- if (node is! Expression) return type;
- if (const bool.fromEnvironment('send_stats') &&
- executableContext != null &&
- // TODO(sigmund): enable also in core libs.
- !executableContext.library.isPlatformLibrary &&
- !type.isDynamic) {
- if (!_fyiShown) {
- print('FYI experiment to collect send stats is on: '
- 'caching types of expressions');
- _fyiShown = true;
- }
- elements.typesCache[node] = type;
- }
- return type;
- }
-
DartType visitSend(Send node) {
Element element = elements[node];
« no previous file with comments | « pkg/compiler/lib/src/info/trusted_types_analysis_result.dart ('k') | tests/compiler/dart2js/dart2js.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698