Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 221423007: Fix upload.py to properly use a local logger (Closed)

Created:
6 years, 8 months ago by agable
Modified:
6 years, 8 months ago
Reviewers:
Dan Jacques, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Fix upload.py to properly use a local logger When rietveld.py overrides upload.py's logging module, it generally works fine... until someone tries to run upload.py with any level of verbosity. Then the calls to logging.getLogger and logging.INFO/logging.DEBUG fail. This patches upload.py to properly use a module-scope logger so that rietveld.py doesn't have to perform invasive surgery, and everything just works. This version of upload.py taken from upstream Rietveld at: changeset: 1267:d7b39eca7dbe branch: chromium R=djacques@chromium.org, maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=262793

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -17 lines) Patch
M rietveld.py View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/upload.py View 12 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
agable
6 years, 8 months ago (2014-04-02 01:25:36 UTC) #1
M-A Ruel
upload.py changes need to go upstream first.
6 years, 8 months ago (2014-04-02 01:29:03 UTC) #2
agable
On 2014/04/02 01:29:03, M-A Ruel wrote: > upload.py changes need to go upstream first. https://codereview.appspot.com/83380043/
6 years, 8 months ago (2014-04-02 01:35:27 UTC) #3
agable
On 2014/04/02 01:35:27, agable wrote: > On 2014/04/02 01:29:03, M-A Ruel wrote: > > upload.py ...
6 years, 8 months ago (2014-04-05 00:27:18 UTC) #4
M-A Ruel
On 2014/04/05 00:27:18, agable wrote: > On 2014/04/02 01:35:27, agable wrote: > > On 2014/04/02 ...
6 years, 8 months ago (2014-04-05 01:23:26 UTC) #5
agable
On 2014/04/05 01:23:26, M-A Ruel wrote: > On 2014/04/05 00:27:18, agable wrote: > > On ...
6 years, 8 months ago (2014-04-05 01:57:15 UTC) #6
agable
On 2014/04/05 01:57:15, agable wrote: > On 2014/04/05 01:23:26, M-A Ruel wrote: > > On ...
6 years, 8 months ago (2014-04-09 19:04:10 UTC) #7
M-A Ruel
On 2014/04/09 19:04:10, agable wrote: > On 2014/04/05 01:57:15, agable wrote: > > On 2014/04/05 ...
6 years, 8 months ago (2014-04-09 20:04:40 UTC) #8
agable
On 2014/04/09 20:04:40, M-A Ruel wrote: > On 2014/04/09 19:04:10, agable wrote: > > On ...
6 years, 8 months ago (2014-04-09 20:17:06 UTC) #9
agable
The CQ bit was checked by agable@chromium.org
6 years, 8 months ago (2014-04-09 20:17:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agable@chromium.org/221423007/1
6 years, 8 months ago (2014-04-09 20:17:23 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 20:19:32 UTC) #12
Message was sent while issue was closed.
Change committed as 262793

Powered by Google App Engine
This is Rietveld 408576698