[DevTools] Introduce unserializableValue in RemoteObject.

third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 312 matching lines @@
     return parseInt(matches[1], 10);
 }
 
 /**
  * @param {!RuntimeAgent.RemoteObject|!WebInspector.RemoteObject|number|string|boolean|undefined|null} object
  * @return {!RuntimeAgent.CallArgument}
  */
 WebInspector.RemoteObject.toCallArgument = function(object)
 {
     var type = typeof object;
-    var value = object;
-    var objectId = undefined;
-    var description = String(object);
+    if (type === "undefined")
+        return {};
+    if (type === "number") {
+        var description = String(object);
+        if (object === 0 && 1 / object < 0)
+            return { unserializableValue: RuntimeAgent.UnserializableValue.Negative0 };
+        if (description === "NaN")
+            return { unserializableValue: RuntimeAgent.UnserializableValue.NaN };
+        if (description === "Infinity")
+            return { unserializableValue: RuntimeAgent.UnserializableValue.Infinity };
+        if (description === "-Infinity")
+            return { unserializableValue: RuntimeAgent.UnserializableValue.NegativeInfinity };
+        return { value: object };
+    }
+    if (type === "string" || type === "boolean")
+        return { value: object };
 
-    if (type === "number" && value === 0 && 1 / value < 0)
-        description = "-0";
+    if (!object)
+        return { value: null };
 
-    switch (type) {
-    case "number":
-    case "string":
-    case "boolean":
-    case "undefined":
-        break;
-    default:
-        if (object) {
-            type = object.type;
-            value = object.value;
-            objectId = object.objectId;
-            description = object.description;
-        }
-        break;
-    }
+    if (typeof object.unserializableValue !== "undefined")

[kozy, 2016/08/05 01:21:02]

Why do you need both checks?

[dgozman, 2016/08/05 02:01:07]

Because it takes both WI.RemoteObject and RA.RemoteObject.

+        return { unserializableValue: object.unserializableValue };
+    if (typeof object._unserializableValue !== "undefined")
+        return { unserializableValue: object._unserializableValue };
 
-    // Handle special numbers: NaN, Infinity, -Infinity, -0.
-    if (type === "number") {
-        switch (description) {
-        case "NaN":
-        case "Infinity":
-        case "-Infinity":
-        case "-0":
-            value = description;
-            break;
-        }
-    }
+    if (typeof object.objectId !== "undefined")
+        return { objectId: object.objectId };
+    if (typeof object._objectId !== "undefined")
+        return { objectId: object._objectId };
 
-    return {
-        value: value,
-        objectId: objectId,
-        type: /** @type {!RuntimeAgent.CallArgumentType.<string>} */ (type)
-    };
+    return { value: object.value };
 }
 
 /**
  * @constructor
  * @extends {WebInspector.RemoteObject}
  * @param {!WebInspector.Target} target
  * @param {string|undefined} objectId
  * @param {string} type
  * @param {string|undefined} subtype
  * @param {*} value
+ * @param {!RuntimeAgent.UnserializableValue=} unserializableValue
  * @param {string=} description
  * @param {!RuntimeAgent.ObjectPreview=} preview
  * @param {!RuntimeAgent.CustomPreview=} customPreview
  */
-WebInspector.RemoteObjectImpl = function(target, objectId, type, subtype, value, description, preview, customPreview)
+WebInspector.RemoteObjectImpl = function(target, objectId, type, subtype, value, unserializableValue, description, preview, customPreview)
 {
     WebInspector.RemoteObject.call(this);
 
     this._target = target;
     this._runtimeAgent = target.runtimeAgent();
     this._debuggerModel = WebInspector.DebuggerModel.fromTarget(target);
 
     this._type = type;
     this._subtype = subtype;
     if (objectId) {
         // handle
         this._objectId = objectId;
         this._description = description;
         this._hasChildren = (type !== "symbol");
         this._preview = preview;
     } else {
         // Primitive or null object.
         this._description = description || (value + "");
         this._hasChildren = false;
-        // Handle special numbers: NaN, Infinity, -Infinity, -0.
-        if (type === "number" && typeof value !== "number")
-            this.value = Number(value);
-        else
+        if (typeof unserializableValue !== "undefined") {
+            this._unserializableValue = unserializableValue;
+            if (unserializableValue === RuntimeAgent.UnserializableValue.Infinity ||
+                unserializableValue === RuntimeAgent.UnserializableValue.NegativeInfinity ||
+                unserializableValue === RuntimeAgent.UnserializableValue.Negative0 ||
+                unserializableValue === RuntimeAgent.UnserializableValue.NaN) {
+                this.value = Number(unserializableValue);
+            } else {
+                this.value = unserializableValue;
+            }
+        } else {
             this.value = value;
+        }
     }
     this._customPreview = customPreview || null;
 }
 
 WebInspector.RemoteObjectImpl.prototype = {
 
     /**
      * @override
      * @return {?RuntimeAgent.CustomPreview}
      */
@@ skipping 486 matching lines @@
 
 /**
  * @constructor
  * @extends {WebInspector.RemoteObjectImpl}
  * @param {!WebInspector.Target} target
  * @param {string|undefined} objectId
  * @param {!WebInspector.ScopeRef} scopeRef
  * @param {string} type
  * @param {string|undefined} subtype
  * @param {*} value
+ * @param {!RuntimeAgent.UnserializableValue=} unserializableValue
  * @param {string=} description
  * @param {!RuntimeAgent.ObjectPreview=} preview
  */
-WebInspector.ScopeRemoteObject = function(target, objectId, scopeRef, type, subtype, value, description, preview)
+WebInspector.ScopeRemoteObject = function(target, objectId, scopeRef, type, subtype, value, unserializableValue, description, preview)
 {
-    WebInspector.RemoteObjectImpl.call(this, target, objectId, type, subtype, value, description, preview);
+    WebInspector.RemoteObjectImpl.call(this, target, objectId, type, subtype, value, unserializableValue, description, preview);
     this._scopeRef = scopeRef;
     this._savedScopeProperties = undefined;
 };
 
 WebInspector.ScopeRemoteObject.prototype = {
     /**
      * @override
      * @param {boolean} ownProperties
      * @param {boolean} accessorPropertiesOnly
      * @param {boolean} generatePreview
@@ skipping 575 matching lines @@
     },
 
     /**
      * @return {!WebInspector.RemoteObject}
      */
     object: function()
     {
         return this._object;
     }
 }