Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1406)

Unified Diff: gm/occludedrrectblur.cpp

Issue 2214163003: Minor clean up related to blur mask filters (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Add comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/effects/SkBlurMaskFilter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/occludedrrectblur.cpp
diff --git a/gm/occludedrrectblur.cpp b/gm/occludedrrectblur.cpp
index da2bf5d38eccf736b320495e27c9b89ba2054810..937b1790cd8cf59eba24911946b6dc2438f0780c 100644
--- a/gm/occludedrrectblur.cpp
+++ b/gm/occludedrrectblur.cpp
@@ -149,7 +149,9 @@ static void draw_90(SkCanvas* canvas, const SkVector& v, SkScalar dist, const Sk
static void draw_90_simple(SkCanvas* canvas, const SkVector& v,
SkScalar dist, const SkPoint& center) {
static const int kLength = 128;
- static const int kWidth = 32;
+ // The width needs to be larger than 2*3*blurRadii+2*cornerRadius for the analytic
+ // RRect blur to kick in
+ static const int kWidth = 47;
SkIRect r;
if (fabs(v.fX) < fabs(v.fY)) {
@@ -293,18 +295,18 @@ protected:
SkVector::Make(kRoot3Over2, -0.5f), 120, center);
draw_45_simple(canvas, SkVector::Make(-SK_ScalarRoot2Over2, -SK_ScalarRoot2Over2),
- 190, center);
+ 210, center);
draw_45_simple(canvas, SkVector::Make(SK_ScalarRoot2Over2, -SK_ScalarRoot2Over2),
- 190, center);
+ 210, center);
draw_45_simple(canvas, SkVector::Make(SK_ScalarRoot2Over2, SK_ScalarRoot2Over2),
- 190, center);
+ 210, center);
draw_45_simple(canvas, SkVector::Make(-SK_ScalarRoot2Over2, SK_ScalarRoot2Over2),
- 190, center);
+ 210, center);
- draw_90_simple(canvas, SkVector::Make(-1.0f, 0.0f), 150, center);
- draw_90_simple(canvas, SkVector::Make(0.0f, -1.0f), 150, center);
- draw_90_simple(canvas, SkVector::Make(1.0f, 0.0f), 150, center);
- draw_90_simple(canvas, SkVector::Make(0.0f, 1.0f), 150, center);
+ draw_90_simple(canvas, SkVector::Make(-1.0f, 0.0f), 160, center);
+ draw_90_simple(canvas, SkVector::Make(0.0f, -1.0f), 160, center);
+ draw_90_simple(canvas, SkVector::Make(1.0f, 0.0f), 160, center);
+ draw_90_simple(canvas, SkVector::Make(0.0f, 1.0f), 160, center);
}
private:
« no previous file with comments | « no previous file | src/effects/SkBlurMaskFilter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698