Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2214123002: add a regression test for #26431, which is now fixed (Closed)

Created:
4 years, 4 months ago by Jennifer Messerly
Modified:
4 years, 4 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

add a test for #26431, which is now fixed likely was fixed by the constructor inference changes R=nweiz@google.com Committed: https://github.com/dart-lang/sdk/commit/3c38f96a0a373e74537dda3880dfe17f3b48f2e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
4 years, 4 months ago (2016-08-04 18:48:14 UTC) #2
nweiz
lgtm
4 years, 4 months ago (2016-08-04 20:40:48 UTC) #3
Jennifer Messerly
4 years, 4 months ago (2016-08-04 22:50:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3c38f96a0a373e74537dda3880dfe17f3b48f2e9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698