Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Issue 2214093002: Make sure there's a table header before attempting to account for its offset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621258-2
Patch Set: 634155 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fragmentation/no-repeating-thead-no-crash-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
index 33371708002255966bb7a4fd0f32d62689690267..0b6d3015034d2a1baf9e95a3ca91de146d70c8b2 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
@@ -1003,7 +1003,7 @@ void LayoutTableSection::layoutRows()
if (paginationStrutOnRow) {
// If there isn't room for at least one content row on a page with a header group, then
// we won't repeat the header on each page.
- if (r == 0 && table()->sectionAbove(this) == table()->header())
+ if (!r && table()->header() && table()->sectionAbove(this) == table()->header())
state.setHeightOffsetForTableHeaders(state.heightOffsetForTableHeaders() - table()->header()->logicalHeight());
// If we have a header group we will paint it at the top of each page, move the rows
// down to accomodate it.
« no previous file with comments | « third_party/WebKit/LayoutTests/fragmentation/no-repeating-thead-no-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698