Issue 2214033002: Add new GM for occluded blurmask filter draws

Issue 2214033002: Add new GM for occluded blurmask filter draws (Closed)

Created:
4 years, 4 months ago by robertphillips

Modified:
4 years, 4 months ago

Reviewers:
jvanverth1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Add new GM for occluded blurmask filter draws This splits out just the GM portion of https://codereview.chromium.org/2201993003/ (Add GM to test out blurmaskfilter occluders) which included some API changes GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2214033002 Committed: https://skia.googlesource.com/skia/+/401c1968a1727b7dd1543f7e5536ca544fc6d752

Patch Set 4 : Appease compilers #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+354 lines, -0 lines)			Patch
A	gm/occludedrrectblur.cpp	View	1 2 3	1 chunk	+320 lines, -0 lines	0 comments	Download
M	tools/sk_tool_utils.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/sk_tool_utils.cpp	View	1 2	1 chunk	+32 lines, -0 lines	0 comments	Download

Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/10328)

4 years, 4 months ago (2016-08-04 16:20:51 UTC) #8

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

robertphillips

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

4 years, 4 months ago (2016-08-04 16:36:31 UTC) #9

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2214033002/20001

4 years, 4 months ago (2016-08-04 16:36:34 UTC) #10

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 4 months ago (2016-08-04 16:39:22 UTC) #11

The CQ bit was unchecked by commit-bot@chromium.org

commit-bot: I haz the power

4 years, 4 months ago (2016-08-04 16:39:23 UTC) #12

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

robertphillips

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

4 years, 4 months ago (2016-08-04 16:49:37 UTC) #13

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2214033002/40001

4 years, 4 months ago (2016-08-04 16:49:43 UTC) #14

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 4 months ago (2016-08-04 16:52:48 UTC) #15

The CQ bit was unchecked by commit-bot@chromium.org

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/10365)

4 years, 4 months ago (2016-08-04 16:52:48 UTC) #16

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86_64-Release-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

robertphillips

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

4 years, 4 months ago (2016-08-04 16:58:26 UTC) #17

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2214033002/60001

4 years, 4 months ago (2016-08-04 16:58:37 UTC) #18

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 4 months ago (2016-08-04 17:28:56 UTC) #19

The CQ bit was unchecked by commit-bot@chromium.org

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

4 years, 4 months ago (2016-08-04 17:28:57 UTC) #20

Dry run: This issue passed the CQ dry run.

jvanverth1

lgtm

4 years, 4 months ago (2016-08-04 19:31:24 UTC) #21

lgtm

robertphillips

The CQ bit was checked by robertphillips@google.com

4 years, 4 months ago (2016-08-04 19:34:39 UTC) #22

The CQ bit was checked by robertphillips@google.com

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2214033002/60001

4 years, 4 months ago (2016-08-04 19:34:48 UTC) #23

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

commit-bot: I haz the power

Description was changed from ========== Add new GM for occluded blurmask filter draws This splits ...

4 years, 4 months ago (2016-08-04 19:35:48 UTC) #24

Message was sent while issue was closed.

Description was changed from

==========
Add new GM for occluded blurmask filter draws

This splits out just the GM portion of
https://codereview.chromium.org/2201993003/ (Add GM to test out blurmaskfilter
occluders) which included some API changes

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2214033002
==========

to

==========
Add new GM for occluded blurmask filter draws

This splits out just the GM portion of
https://codereview.chromium.org/2201993003/ (Add GM to test out blurmaskfilter
occluders) which included some API changes

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2214033002

Committed:
https://skia.googlesource.com/skia/+/401c1968a1727b7dd1543f7e5536ca544fc6d752
==========

commit-bot: I haz the power

Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/401c1968a1727b7dd1543f7e5536ca544fc6d752

4 years, 4 months ago (2016-08-04 19:35:49 UTC) #25

Message was sent while issue was closed.

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/401c1968a1727b7dd1543f7e5536ca544fc6d752

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages