Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2214023002: GN: make SkPMColor BGRA on Linux. All other platforms are auto-detected. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: make SkPMColor BGRA on Linux. All other platforms are auto-detected. This technically shouldn't cause us to draw differently, but sometimes does on buggy GMs, and also has us go down slightly different code paths. It's good to be consistent with GYP, Chromium, Google3, etc. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2214023002 Committed: https://skia.googlesource.com/skia/+/ee269f44d9caf550ef3ddb059664224df7ec3b65

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
mtklein_C
4 years, 4 months ago (2016-08-04 15:57:57 UTC) #5
mtklein_C
My horse for a review!
4 years, 4 months ago (2016-08-04 16:08:35 UTC) #7
mtklein_C
No, wait, my kingdom for a code review!
4 years, 4 months ago (2016-08-04 16:09:34 UTC) #8
robertphillips
lgtm
4 years, 4 months ago (2016-08-04 16:50:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2214023002/1
4 years, 4 months ago (2016-08-04 16:51:18 UTC) #13
mtklein_C
On 2016/08/04 at 16:50:44, robertphillips wrote: > lgtm Fooled you, my kingdom is not very ...
4 years, 4 months ago (2016-08-04 16:51:36 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 16:52:14 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ee269f44d9caf550ef3ddb059664224df7ec3b65

Powered by Google App Engine
This is Rietveld 408576698