Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 22140002: IDL lexer: update integer regex to latest Web IDL spec (Closed)

Created:
7 years, 4 months ago by Nils Barth (inactive)
Modified:
7 years, 4 months ago
Reviewers:
noelallen1
CC:
chromium-reviews, haraken, kojih
Visibility:
Public.

Description

IDL lexer: update integer regex to latest Web IDL spec The regex for integers in Web IDL was just updated. This doesn't change behavior, but improves clarity a bit. This CL updates us to this new regex. Relevant W3C bug: Bug 19778 - Wrong regex for integer https://www.w3.org/Bugs/Public/show_bug.cgi?id=19778 TEST=idl_lexer_test.py Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216080

Patch Set 1 #

Patch Set 2 : More tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M tools/idl_parser/idl_lexer.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/idl_parser/test_lexer/values.in View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
Hi Noel, Quick CL keeping us up-to-date with spec.
7 years, 4 months ago (2013-08-05 05:47:34 UTC) #1
noelallen1
LGTM assuming we have the appropriate lexer tests already for octal.
7 years, 4 months ago (2013-08-06 14:52:08 UTC) #2
Nils Barth (inactive)
On 2013/08/06 14:52:08, noelallen1 wrote: > LGTM assuming we have the appropriate lexer tests already ...
7 years, 4 months ago (2013-08-07 01:08:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/22140002/5001
7 years, 4 months ago (2013-08-07 01:18:42 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-07 05:08:15 UTC) #5
Message was sent while issue was closed.
Change committed as 216080

Powered by Google App Engine
This is Rietveld 408576698