Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Issue 2213963002: Stop relying on using statements in the JNI generator. (Closed)

Created:
4 years, 4 months ago by Torne
Modified:
4 years, 4 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop relying on using statements in the JNI generator. Instead of emitting unqualified references to JavaParamRef and ScopedJavaLocalRef, just qualify them with base::android. This is the first step to allow the "using" statements for these types to be removed from jni_generator_helper.h. BUG=568574 Committed: https://crrev.com/7537dfb15e54ebab0cc9d4820a826fa350fee320 Cr-Commit-Position: refs/heads/master@{#409794}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -204 lines) Patch
M base/android/jni_generator/golden_sample_for_tests_jni.h View 11 chunks +42 lines, -33 lines 0 comments Download
M base/android/jni_generator/jni_generator.py View 4 chunks +6 lines, -4 lines 0 comments Download
M base/android/jni_generator/testCalledByNatives.golden View 17 chunks +43 lines, -41 lines 0 comments Download
M base/android/jni_generator/testConstantsFromJavaP.golden View 16 chunks +45 lines, -40 lines 0 comments Download
M base/android/jni_generator/testFromJavaP.golden View 2 chunks +5 lines, -4 lines 0 comments Download
M base/android/jni_generator/testInnerClassNatives.golden View 1 chunk +3 lines, -2 lines 0 comments Download
M base/android/jni_generator/testInnerClassNativesBothInnerAndOuter.golden View 1 chunk +6 lines, -4 lines 0 comments Download
M base/android/jni_generator/testInnerClassNativesMultiple.golden View 1 chunk +6 lines, -4 lines 0 comments Download
M base/android/jni_generator/testMultipleJNIAdditionalImport.golden View 1 chunk +7 lines, -6 lines 0 comments Download
M base/android/jni_generator/testNativeExportsOnlyOption.golden View 6 chunks +14 lines, -10 lines 0 comments Download
M base/android/jni_generator/testNatives.golden View 7 chunks +64 lines, -51 lines 0 comments Download
M base/android/jni_generator/testNativesLong.golden View 1 chunk +2 lines, -1 line 0 comments Download
M base/android/jni_generator/testSingleJNIAdditionalImport.golden View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Torne
4 years, 4 months ago (2016-08-04 13:29:40 UTC) #2
rmcilroy
LGTM, thanks
4 years, 4 months ago (2016-08-04 15:07:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2213963002/1
4 years, 4 months ago (2016-08-04 15:09:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 15:44:21 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 15:46:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7537dfb15e54ebab0cc9d4820a826fa350fee320
Cr-Commit-Position: refs/heads/master@{#409794}

Powered by Google App Engine
This is Rietveld 408576698