Relanding: MD Settings: Adding some unit tests for <settings-main>.

Relanding: MD Settings: Adding some unit tests for <settings-main>.

Initial commit was reverted at https://codereview.chromium.org/2217493002
because the tests failed when run in debug bots. The
issue causing this is now fixed.

Specifically testing the "no results" message is shown/hidden as expected.
  - Splitting SearchManager to an interface and an implementation.
  - Using a TestSearchManager class (implements SearchManager) for testing
    <settings-main>.

BUG=630383
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1c22a24eea98efce6f07c71706668cbc2ca71b3f
Cr-Commit-Position: refs/heads/master@{#409887}

[dpapad, 2016-08-04 18:51:24]

Description was changed from

==========
Relanding: MD Settings: Adding some unit tests for <settings-main>.

Initial commit was reverted because the tests failed when run in debug bots. The
issue causing this is now fixed.

BUG=630383
==========

to

==========
Relanding: MD Settings: Adding some unit tests for <settings-main>.

Initial commit was reverted because the tests failed when run in debug bots. The
issue causing this is now fixed.

BUG=630383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-08-04 18:53:49]

Description was changed from

==========
Relanding: MD Settings: Adding some unit tests for <settings-main>.

Initial commit was reverted because the tests failed when run in debug bots. The
issue causing this is now fixed.

BUG=630383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Relanding: MD Settings: Adding some unit tests for <settings-main>.

Initial commit was reverted at https://codereview.chromium.org/2217493002
because the tests failed when run in debug bots. The
issue causing this is now fixed.

Specifically testing the "no results" message is shown/hidden as expected.
  - Splitting SearchManager to an interface and an implementation.
  - Using a TestSearchManager class (implements SearchManager) for testing
    <settings-main>.

BUG=630383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-08-04 18:54:43]

dpapad@chromium.org changed reviewers:
+ michaelpg@chromium.org

[dpapad, 2016-08-04 18:55:11]

FYI, the only difference with previous attempt is inside suiteSetup() in the
test file.

[michaelpg, 2016-08-04 18:57:11]

cursory lgtm based on last CL and our discussion

[dpapad, 2016-08-04 19:08:25]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-08-04 19:08:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 19:17:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 19:17:28]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dpapad, 2016-08-04 19:43:08]

Description was changed from

==========
Relanding: MD Settings: Adding some unit tests for <settings-main>.

Initial commit was reverted at https://codereview.chromium.org/2217493002
because the tests failed when run in debug bots. The
issue causing this is now fixed.

Specifically testing the "no results" message is shown/hidden as expected.
  - Splitting SearchManager to an interface and an implementation.
  - Using a TestSearchManager class (implements SearchManager) for testing
    <settings-main>.

BUG=630383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Relanding: MD Settings: Adding some unit tests for <settings-main>.

Initial commit was reverted at https://codereview.chromium.org/2217493002
because the tests failed when run in debug bots. The
issue causing this is now fixed.

Specifically testing the "no results" message is shown/hidden as expected.
  - Splitting SearchManager to an interface and an implementation.
  - Using a TestSearchManager class (implements SearchManager) for testing
    <settings-main>.

BUG=630383
NOPRESUBMIT=true 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-08-04 19:43:13]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-08-04 19:43:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 20:30:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-04 20:31:47]

Description was changed from

==========
Relanding: MD Settings: Adding some unit tests for <settings-main>.

Initial commit was reverted at https://codereview.chromium.org/2217493002
because the tests failed when run in debug bots. The
issue causing this is now fixed.

Specifically testing the "no results" message is shown/hidden as expected.
  - Splitting SearchManager to an interface and an implementation.
  - Using a TestSearchManager class (implements SearchManager) for testing
    <settings-main>.

BUG=630383
NOPRESUBMIT=true 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Relanding: MD Settings: Adding some unit tests for <settings-main>.

Initial commit was reverted at https://codereview.chromium.org/2217493002
because the tests failed when run in debug bots. The
issue causing this is now fixed.

Specifically testing the "no results" message is shown/hidden as expected.
  - Splitting SearchManager to an interface and an implementation.
  - Using a TestSearchManager class (implements SearchManager) for testing
    <settings-main>.

BUG=630383
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1c22a24eea98efce6f07c71706668cbc2ca71b3f
Cr-Commit-Position: refs/heads/master@{#409887}
==========

[commit-bot: I haz the power, 2016-08-04 20:31:48]

Patchset 1 (id:??) landed as
https://crrev.com/1c22a24eea98efce6f07c71706668cbc2ca71b3f
Cr-Commit-Position: refs/heads/master@{#409887}