Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: base/threading/thread_checker_unittest.cc

Issue 2213933003: Change EXPECT/ASSERT_DCHECK_DEATH macro to not expose the |regex| parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b2b0_simplethreadJoinable
Patch Set: Fix SchedulerLock unittests to actually generate a DCHECK, not an exception Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/threading/thread_checker_unittest.cc
diff --git a/base/threading/thread_checker_unittest.cc b/base/threading/thread_checker_unittest.cc
index 1b254a1fff29999ce7e8e764e126d9df92ec00f7..10ef2cec44a28655d11805934286e29339086eb6 100644
--- a/base/threading/thread_checker_unittest.cc
+++ b/base/threading/thread_checker_unittest.cc
@@ -125,8 +125,7 @@ void ThreadCheckerClass::MethodOnDifferentThreadImpl() {
#if DCHECK_IS_ON()
TEST(ThreadCheckerDeathTest, MethodNotAllowedOnDifferentThreadInDebug) {
- ASSERT_DCHECK_DEATH({ ThreadCheckerClass::MethodOnDifferentThreadImpl(); },
- "");
+ ASSERT_DCHECK_DEATH({ ThreadCheckerClass::MethodOnDifferentThreadImpl(); });
}
#else
TEST(ThreadCheckerTest, MethodAllowedOnDifferentThreadInRelease) {
@@ -154,7 +153,7 @@ void ThreadCheckerClass::DetachThenCallFromDifferentThreadImpl() {
#if DCHECK_IS_ON()
TEST(ThreadCheckerDeathTest, DetachFromThreadInDebug) {
ASSERT_DCHECK_DEATH(
- { ThreadCheckerClass::DetachThenCallFromDifferentThreadImpl(); }, "");
+ { ThreadCheckerClass::DetachThenCallFromDifferentThreadImpl(); });
}
#else
TEST(ThreadCheckerTest, DetachFromThreadInRelease) {

Powered by Google App Engine
This is Rietveld 408576698