base/task_scheduler/priority_queue_unittest.cc - Issue 2213933003: Change EXPECT/ASSERT_DCHECK_DEATH macro to not expose the |regex| parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/task_scheduler/priority_queue_unittest.cc

Issue 2213933003: Change EXPECT/ASSERT_DCHECK_DEATH macro to not expose the |regex| parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b2b0_simplethreadJoinable

Patch Set: Fix SchedulerLock unittests to actually generate a DCHECK, not an exception Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/synchronization/atomic_flag_unittest.cc ('k') | base/task_scheduler/scheduler_lock_impl.cc » ('j') | base/task_scheduler/scheduler_lock_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/task_scheduler/priority_queue_unittest.cc

diff --git a/base/task_scheduler/priority_queue_unittest.cc b/base/task_scheduler/priority_queue_unittest.cc

index f1e3a0d06eb4842176b4fbada5f2584771e1fc86..3984a2152153f98fb120b8f9c08236786bc7f7e6 100644

--- a/base/task_scheduler/priority_queue_unittest.cc

+++ b/base/task_scheduler/priority_queue_unittest.cc

@@ -138,8 +138,7 @@ TEST(TaskSchedulerPriorityQueueTest, IllegalTwoTransactionsSameThread) {

pq_a.BeginTransaction();

std::unique_ptr<PriorityQueue::Transaction> transaction_b =

pq_b.BeginTransaction();

- },

- "");

+ });

}

// Check that there is no crash when Transactions are created on the same thread

« no previous file with comments | « base/synchronization/atomic_flag_unittest.cc ('k') | base/task_scheduler/scheduler_lock_impl.cc » ('j') | base/task_scheduler/scheduler_lock_impl.cc » ('J')