base/metrics/persistent_sample_map_unittest.cc - Issue 2213933003: Change EXPECT/ASSERT_DCHECK_DEATH macro to not expose the |regex| parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/persistent_sample_map_unittest.cc

Issue 2213933003: Change EXPECT/ASSERT_DCHECK_DEATH macro to not expose the |regex| parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b2b0_simplethreadJoinable

Patch Set: Fix SchedulerLock unittests to actually generate a DCHECK, not an exception Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/metrics/persistent_sample_map_unittest.cc

diff --git a/base/metrics/persistent_sample_map_unittest.cc b/base/metrics/persistent_sample_map_unittest.cc

index 91bd0a9d9074883e41c928b72ba796bd0a2b4ce5..c3f2474b8617ef30a6cb60c12626cc836b70987d 100644

--- a/base/metrics/persistent_sample_map_unittest.cc

+++ b/base/metrics/persistent_sample_map_unittest.cc

@@ -247,9 +247,9 @@ TEST(PersistentSampleMapIteratorDeathTest, IterateDoneTest) {

HistogramBase::Sample min;

HistogramBase::Sample max;

HistogramBase::Count count;

- EXPECT_DCHECK_DEATH(it->Get(&min, &max, &count), "");

+ EXPECT_DCHECK_DEATH(it->Get(&min, &max, &count));

- EXPECT_DCHECK_DEATH(it->Next(), "");

+ EXPECT_DCHECK_DEATH(it->Next());

samples.Accumulate(1, 100);

it = samples.Iterator();

« no previous file with comments | « base/metrics/histogram_unittest.cc ('k') | base/metrics/sample_map_unittest.cc » ('j') | base/task_scheduler/scheduler_lock_impl.cc » ('J')