Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: base/task_scheduler/task_tracker_unittest.cc

Issue 2213933003: Change EXPECT/ASSERT_DCHECK_DEATH macro to not expose the |regex| parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b2b0_simplethreadJoinable
Patch Set: Disabling a death test which crashed instead of DCHECKing : http://crbug.com/634552 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/task_scheduler/scheduler_worker_stack_unittest.cc ('k') | base/test/gtest_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/task_tracker_unittest.cc
diff --git a/base/task_scheduler/task_tracker_unittest.cc b/base/task_scheduler/task_tracker_unittest.cc
index 2602e3735b0ef129fb585b00ef043ae3e8d997f9..bbfff4285687b59c2f46f38d138de707395c284f 100644
--- a/base/task_scheduler/task_tracker_unittest.cc
+++ b/base/task_scheduler/task_tracker_unittest.cc
@@ -354,7 +354,7 @@ TEST_P(TaskSchedulerTaskTrackerTest, WillPostAfterShutdown) {
// |task_tracker_| shouldn't allow a task to be posted after shutdown.
if (GetParam() == TaskShutdownBehavior::BLOCK_SHUTDOWN) {
- EXPECT_DCHECK_DEATH({ tracker_.WillPostTask(task.get()); }, "");
+ EXPECT_DCHECK_DEATH({ tracker_.WillPostTask(task.get()); });
} else {
EXPECT_FALSE(tracker_.WillPostTask(task.get()));
}
@@ -382,12 +382,13 @@ TEST_P(TaskSchedulerTaskTrackerTest, SingletonAllowed) {
tracker.RunNextTaskInSequence(
CreateSequenceWithTask(std::move(task)).get());
} else {
+#if !defined(OS_LINUX) // http://crbug.com/634552
EXPECT_DCHECK_DEATH(
{
tracker.RunNextTaskInSequence(
CreateSequenceWithTask(std::move(task)).get());
- },
- "");
+ });
+#endif // !defined(OS_LINUX)
}
}
« no previous file with comments | « base/task_scheduler/scheduler_worker_stack_unittest.cc ('k') | base/test/gtest_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698