Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: dbus/values_util.h

Issue 221393004: dbus/values_util.h: Add functions to append collection type values to message. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dbus/values_util.h
diff --git a/dbus/values_util.h b/dbus/values_util.h
index e34c7a039db31e611fccad4be2285e07a4a3423c..70365a74289b25143f91c146cd74043c9b548cad 100644
--- a/dbus/values_util.h
+++ b/dbus/values_util.h
@@ -22,15 +22,33 @@ class MessageWriter;
// double. Non-string diciontary keys are converted to strings.
CHROME_DBUS_EXPORT base::Value* PopDataAsValue(MessageReader* reader);
-// Appends a basic type value to |writer|.
+// DEPRECATED: Use AppendValueData instead.
+// Appends a basic type value to |writer|. Basic types are BOOLEAN, INTEGER,
+// DOUBLE, and STRING.
CHROME_DBUS_EXPORT void AppendBasicTypeValueData(MessageWriter* writer,
const base::Value& value);
-// Appends a basic type value to |writer| as a variant.
+// DEPRECATED: Use AppendValueDataAsVariant instead.
+// Appends a basic type value to |writer| as a variant. Basic types are BOOLEAN,
+// INTEGER, DOUBLE, and STRING.
CHROME_DBUS_EXPORT void AppendBasicTypeValueDataAsVariant(
MessageWriter* writer,
const base::Value& value);
+// Appends a value to |writer|. Value can be a basic type, as well as a
+// collection type, such as dictionary or list. Collections will be written as
+// variant containers, i.e. dictionaries will be written with type a{sv} and
+// lists with type av.
+CHROME_DBUS_EXPORT void AppendValueData(MessageWriter* writer,
+ const base::Value& value);
+
+// Appends a value to |writer| as a variant. Value can be a basic type, as well
+// as a collection type, such as dictionary or list. Collections will be written
+// as variant containers, i.e. dictionaries will be written with type a{sv} and
+// lists with type av.
+CHROME_DBUS_EXPORT void AppendValueDataAsVariant(MessageWriter* writer,
+ const base::Value& value);
+
} // namespace dbus
#endif // DBUS_VALUES_UTIL_H_

Powered by Google App Engine
This is Rietveld 408576698