Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Issue 2213903002: Make ScriptForbiddenScope inlineable (Closed)

Created:
4 years, 4 months ago by Camillo Bruni
Modified:
4 years, 4 months ago
Reviewers:
esprehn
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ScriptForbiddenScope inlineable Stack allocated scopes work considerably faster if they have inlineable constructors and destructors. This CL moves ScriptForbiddenScope to it's header file. BUG=chromium:630217 Committed: https://crrev.com/c247b6bc05d0695d85b1a3c2343d2bb14c18018d Cr-Commit-Position: refs/heads/master@{#410209}

Patch Set 1 #

Total comments: 1

Patch Set 2 : moving count variable to private static member #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -60 lines) Patch
M third_party/WebKit/Source/platform/ScriptForbiddenScope.h View 1 2 chunks +41 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/ScriptForbiddenScope.cpp View 1 1 chunk +1 line, -51 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Camillo Bruni
PTAL
4 years, 4 months ago (2016-08-04 12:08:01 UTC) #2
esprehn
https://codereview.chromium.org/2213903002/diff/1/third_party/WebKit/Source/platform/ScriptForbiddenScope.h File third_party/WebKit/Source/platform/ScriptForbiddenScope.h (right): https://codereview.chromium.org/2213903002/diff/1/third_party/WebKit/Source/platform/ScriptForbiddenScope.h#newcode15 third_party/WebKit/Source/platform/ScriptForbiddenScope.h:15: static unsigned s_scriptForbiddenCount = 0; Hmm I didn't think ...
4 years, 4 months ago (2016-08-04 18:34:44 UTC) #3
esprehn
lgtm
4 years, 4 months ago (2016-08-05 21:00:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2213903002/20001
4 years, 4 months ago (2016-08-05 21:01:21 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-05 23:36:22 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 23:37:46 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c247b6bc05d0695d85b1a3c2343d2bb14c18018d
Cr-Commit-Position: refs/heads/master@{#410209}

Powered by Google App Engine
This is Rietveld 408576698