Fixed MediaQueryTokenizer escape support

Fixed MediaQueryTokenizer escape support

MediaQueryTokenizer handling of escapes was faulty, causing media queries with escaped code points to be considered invalid.
This CL fixes that.

BUG=358833
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170704

[Yoav Weiss, 2014-04-01 21:55:40]

The tokenizer escape support had a bug. This fixes it.

This bug is not a regression, since the BisonCSSParser also fails to handle
escapes properly.

[eseidel, 2014-04-01 22:03:06]

lgtm

https://codereview.chromium.org/221383003/diff/1/Source/core/css/MediaQuerySe...
File Source/core/css/MediaQuerySetTest.cpp (right):

https://codereview.chromium.org/221383003/diff/1/Source/core/css/MediaQuerySe...
Source/core/css/MediaQuerySetTest.cpp:114: RefPtrWillBeRawPtr<MediaQuerySet>
querySet = MediaQuerySet::createOffMainThread(testCases[i].input);
Seems like we should test both parsers, no?  Run the same tests through both,
just have a way to allow the old one to fail some?

[Yoav Weiss, 2014-04-02 03:57:08]

On 2014/04/01 22:03:06, eseidel wrote:
> lgtm
> 
>
https://codereview.chromium.org/221383003/diff/1/Source/core/css/MediaQuerySe...
> File Source/core/css/MediaQuerySetTest.cpp (right):
> 
>
https://codereview.chromium.org/221383003/diff/1/Source/core/css/MediaQuerySe...
> Source/core/css/MediaQuerySetTest.cpp:114: RefPtrWillBeRawPtr<MediaQuerySet>
> querySet = MediaQuerySet::createOffMainThread(testCases[i].input);
> Seems like we should test both parsers, no?  Run the same tests through both,
> just have a way to allow the old one to fail some?

Since this was a mistake I've switched this back. I'll add a way to test both
parsers as a separate CL.

[Yoav Weiss, 2014-04-02 03:57:09]

On 2014/04/01 22:03:06, eseidel wrote:
> lgtm
> 
>
https://codereview.chromium.org/221383003/diff/1/Source/core/css/MediaQuerySe...
> File Source/core/css/MediaQuerySetTest.cpp (right):
> 
>
https://codereview.chromium.org/221383003/diff/1/Source/core/css/MediaQuerySe...
> Source/core/css/MediaQuerySetTest.cpp:114: RefPtrWillBeRawPtr<MediaQuerySet>
> querySet = MediaQuerySet::createOffMainThread(testCases[i].input);
> Seems like we should test both parsers, no?  Run the same tests through both,
> just have a way to allow the old one to fail some?

Since this was a mistake I've switched this back. I'll add a way to test both
parsers as a separate CL.

[eseidel, 2014-04-02 04:30:17]

lgtm

[commit-bot: I haz the power, 2014-04-02 04:30:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoav@yoav.ws/221383003/20001

[commit-bot: I haz the power, 2014-04-02 04:43:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-02 04:43:29]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[Yoav Weiss, 2014-04-02 19:53:33]

The CQ bit was checked by yoav@yoav.ws

[commit-bot: I haz the power, 2014-04-02 19:53:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoav@yoav.ws/221383003/40001

[commit-bot: I haz the power, 2014-04-02 20:06:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-02 20:06:44]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_rel

[Yoav Weiss, 2014-04-02 20:34:58]

The CQ bit was checked by yoav@yoav.ws

[commit-bot: I haz the power, 2014-04-02 20:35:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoav@yoav.ws/221383003/60001

[commit-bot: I haz the power, 2014-04-02 21:38:12]

Change committed as 170704