Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 2213793003: By default, don't clear exceptions in JSEntryStub (Closed)

Created:
4 years, 4 months ago by jgruber
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

By default, don't clear exceptions in JSEntryStub BUG=v8:5259 R=yangguo@chromium.org Committed: https://crrev.com/887952e8c36038cf98c1db290a565941d2cad71b Cr-Commit-Position: refs/heads/master@{#38330}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
jgruber
4 years, 4 months ago (2016-08-04 07:35:25 UTC) #3
Yang
lgtm
4 years, 4 months ago (2016-08-04 07:38:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2213793003/1
4 years, 4 months ago (2016-08-04 08:33:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 08:47:21 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 08:49:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/887952e8c36038cf98c1db290a565941d2cad71b
Cr-Commit-Position: refs/heads/master@{#38330}

Powered by Google App Engine
This is Rietveld 408576698