Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2213783002: s390: Remove OrComplement and andComplement (Closed)

Created:
4 years, 4 months ago by john.yan
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390: Remove OrComplement and andComplement OrComplement and AndComplement has no native support on s390. So remove them. R=joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG= Committed: https://crrev.com/f32577f648a15a184d05b03b1aaa0ea3e0384d43 Cr-Commit-Position: refs/heads/master@{#38341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -70 lines) Patch
M src/compiler/s390/code-generator-s390.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/compiler/s390/instruction-codes-s390.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/s390/instruction-scheduler-s390.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 3 chunks +4 lines, -58 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 4 months ago (2016-08-04 04:29:53 UTC) #1
JaideepBajwa
lgtm
4 years, 4 months ago (2016-08-04 13:19:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2213783002/1
4 years, 4 months ago (2016-08-04 13:21:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 13:41:36 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 13:45:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f32577f648a15a184d05b03b1aaa0ea3e0384d43
Cr-Commit-Position: refs/heads/master@{#38341}

Powered by Google App Engine
This is Rietveld 408576698