Expand scope of enable_hotwording. (try 2)

Expand scope of enable_hotwording. (try 2)

It is currently only in chrome/browser/BUILD.gn even though it is used
elsewhere. Moving it to chrome/common/features.gni and checking for it
where it is used.

BUG=634044
Previous attempt: https://codereview.chromium.org/2209843002/

Committed: https://crrev.com/0e3086f5ce38b1837685327e1d3d53f57ac7fcd0
Cr-Commit-Position: refs/heads/master@{#409720}

[Lei Zhang, 2016-08-04 00:59:06]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 00:59:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-08-04 01:02:06]

thestig@chromium.org changed reviewers:
+ dpranke@chromium.org

[Lei Zhang, 2016-08-04 01:02:07]

Trying again. See Patch set 1 -> 3.

I tried to repro quickly by building
../../chrome/browser/extensions/component_extensions_whitelist/whitelist.cc^

https://codereview.chromium.org/2213713002/diff/40001/chrome/common/features.gni
File chrome/common/features.gni (right):

https://codereview.chromium.org/2213713002/diff/40001/chrome/common/features....
chrome/common/features.gni:49: "enable_hotwording=$enable_hotwording",
The <if expr="enable_hotwording"> in chrome/browser/browser_resources.grd never
evaluated to true previously, but grit happily generated all the resources
anyway. Once I fixed that, it exposed this problem.

[Lei Zhang, 2016-08-04 01:02:37]

On 2016/08/04 01:02:07, Lei Zhang wrote:
> I tried to repro quickly by building
> ../../chrome/browser/extensions/component_extensions_whitelist/whitelist.cc^

... and it failed so patch set 2 fixes that.

[Dirk Pranke, 2016-08-04 01:16:49]

ok, lgtm.

[commit-bot: I haz the power, 2016-08-04 02:38:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 02:38:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Lei Zhang, 2016-08-04 04:04:46]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-08-04 04:05:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 04:44:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-04 04:46:01]

Description was changed from

==========
Expand scope of enable_hotwording. (try 2)

It is currently only in chrome/browser/BUILD.gn even though it is used
elsewhere. Moving it to chrome/common/features.gni and checking for it
where it is used.

BUG=634044
Previous attempt: https://codereview.chromium.org/2209843002/
==========

to

==========
Expand scope of enable_hotwording. (try 2)

It is currently only in chrome/browser/BUILD.gn even though it is used
elsewhere. Moving it to chrome/common/features.gni and checking for it
where it is used.

BUG=634044
Previous attempt: https://codereview.chromium.org/2209843002/

Committed: https://crrev.com/0e3086f5ce38b1837685327e1d3d53f57ac7fcd0
Cr-Commit-Position: refs/heads/master@{#409720}
==========

[commit-bot: I haz the power, 2016-08-04 04:46:01]

Patchset 3 (id:??) landed as
https://crrev.com/0e3086f5ce38b1837685327e1d3d53f57ac7fcd0
Cr-Commit-Position: refs/heads/master@{#409720}